net/http/http_proxy_client_socket_pool.cc - Issue 18546008: [SPDY] Use WeakPtr<SpdySession> everywhere but SpdySessionPool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_proxy_client_socket_pool.cc

Issue 18546008: [SPDY] Use WeakPtr<SpdySession> everywhere but SpdySessionPool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix test, other minor formatting/comment changes Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_proxy_client_socket_pool.cc

diff --git a/net/http/http_proxy_client_socket_pool.cc b/net/http/http_proxy_client_socket_pool.cc

index 5249f5b4072376330ddd29d8d39c69f431466dc4..b80df37b3dd0f33ef9b41f35a025e146b50df955 100644

--- a/net/http/http_proxy_client_socket_pool.cc

+++ b/net/http/http_proxy_client_socket_pool.cc

@@ -302,7 +302,7 @@ int HttpProxyConnectJob::DoSpdyProxyCreateStream() {

ProxyServer::Direct(),

kPrivacyModeDisabled);

SpdySessionPool* spdy_pool = params_->spdy_session_pool();

- scoped_refptr<SpdySession> spdy_session =

+ base::WeakPtr<SpdySession> spdy_session =

spdy_pool->FindAvailableSession(key, net_log());

// It's possible that a session to the proxy has recently been created

if (spdy_session) {

« no previous file with comments | « net/http/http_network_transaction_unittest.cc ('k') | net/http/http_stream_factory_impl.h » ('j') | no next file with comments »