scm.py - Issue 18541006: If we're running in nohooks mode, don't bother to accumulate file_list in gclient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scm.py

Issue 18541006: If we're running in nohooks mode, don't bother to accumulate file_list in gclient. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Rebase and mark the rest of the optional args Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scm.py

diff --git a/scm.py b/scm.py

index d0ae572c93c9bffc6a9b268c19cbf58e041c318f..8810c2aa2603535eb9937e080c015393acb92ae2 100644

--- a/scm.py

+++ b/scm.py

@@ -512,6 +512,9 @@ class SVN(object):

Error: An error occurred while running the svn command.

"""

stdout = stdout or sys.stdout

+ if file_list is None:

+ # Even if our caller doesn't care about file_list, we use it internally.

+ file_list = []

# svn update and svn checkout use the same pattern: the first three columns

# are for file status, property status, and lock status. This is followed

« no previous file with comments | « gclient_scm.py ('k') | no next file » | no next file with comments »