content/renderer/media/pepper_platform_video_decoder.cc - Issue 185403020: Make VEA client of command buffer; move sync. IPC to VDA/VEA::Initialize()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/pepper_platform_video_decoder.cc

Issue 185403020: Make VEA client of command buffer; move sync. IPC to VDA/VEA::Initialize() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: 7da5b6ec Rebase. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/pepper_platform_video_decoder.h ('k') | content/renderer/media/renderer_gpu_video_accelerator_factories.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/pepper_platform_video_decoder.cc

diff --git a/content/renderer/media/pepper_platform_video_decoder.cc b/content/renderer/media/pepper_platform_video_decoder.cc

index 37a19d3ec663fba56aa5b9a8e5dfbefee2c2c7a8..ca1d2f23f6cc70219c0baf92ac0e5f49c509bb26 100644

--- a/content/renderer/media/pepper_platform_video_decoder.cc

+++ b/content/renderer/media/pepper_platform_video_decoder.cc

@@ -40,7 +40,7 @@ bool PlatformVideoDecoder::Initialize(

return false;

// Send IPC message to initialize decoder in GPU process.

- decoder_ = channel->CreateVideoDecoder(command_buffer_route_id_, profile);

+ decoder_ = channel->CreateVideoDecoder(command_buffer_route_id_);

return (decoder_ && decoder_->Initialize(profile, this));

}

@@ -102,10 +102,6 @@ void PlatformVideoDecoder::PictureReady(const media::Picture& picture) {

client_->PictureReady(picture);

}

-void PlatformVideoDecoder::NotifyInitializeDone() {

- NOTREACHED() << "GpuVideoDecodeAcceleratorHost::Initialize is synchronous!";

void PlatformVideoDecoder::NotifyEndOfBitstreamBuffer(

int32 bitstream_buffer_id) {

DCHECK(RenderThreadImpl::current());