Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: content/common/gpu/media/gpu_video_decode_accelerator.h

Issue 185403020: Make VEA client of command buffer; move sync. IPC to VDA/VEA::Initialize() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: 7da5b6ec Rebase. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/media/gpu_video_decode_accelerator.h
diff --git a/content/common/gpu/media/gpu_video_decode_accelerator.h b/content/common/gpu/media/gpu_video_decode_accelerator.h
index c22608b854f1c754d6d98dbe2462ecef119ceb60..0511550ff367679861b6db20ed9ddd507bb3213b 100644
--- a/content/common/gpu/media/gpu_video_decode_accelerator.h
+++ b/content/common/gpu/media/gpu_video_decode_accelerator.h
@@ -49,7 +49,6 @@ class GpuVideoDecodeAccelerator
uint32 texture_target) OVERRIDE;
virtual void DismissPictureBuffer(int32 picture_buffer_id) OVERRIDE;
virtual void PictureReady(const media::Picture& picture) OVERRIDE;
- virtual void NotifyInitializeDone() OVERRIDE;
virtual void NotifyError(media::VideoDecodeAccelerator::Error error) OVERRIDE;
virtual void NotifyEndOfBitstreamBuffer(int32 bitstream_buffer_id) OVERRIDE;
virtual void NotifyFlushDone() OVERRIDE;
@@ -63,8 +62,6 @@ class GpuVideoDecodeAccelerator
// Initialize the accelerator with the given profile and send the
// |init_done_msg| when done.
- // The renderer process handle is valid as long as we have a channel between
- // GPU process and the renderer.
void Initialize(const media::VideoCodecProfile profile,
IPC::Message* init_done_msg);
@@ -89,15 +86,15 @@ class GpuVideoDecodeAccelerator
// Sets the texture to cleared.
void SetTextureCleared(const media::Picture& picture);
- // Message to Send() when initialization is done. Is only non-NULL during
- // initialization and is owned by the IPC channel underlying the
- // GpuCommandBufferStub.
- IPC::Message* init_done_msg_;
+ // Helper for replying to the creation request.
+ void SendCreateDecoderReply(IPC::Message* message, int32 route_id);
// Route ID to communicate with the host.
int32 host_route_id_;
- // Unowned pointer to the underlying GpuCommandBufferStub.
+ // Unowned pointer to the underlying GpuCommandBufferStub. |this| is
+ // registered as a DestuctionObserver of |stub_| and will self-delete when
+ // |stub_| is destroyed.
GpuCommandBufferStub* stub_;
// The underlying VideoDecodeAccelerator.
« no previous file with comments | « content/common/gpu/media/exynos_video_encode_accelerator.cc ('k') | content/common/gpu/media/gpu_video_decode_accelerator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698