Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: media/video/video_decode_accelerator.h

Issue 185403020: Make VEA client of command buffer; move sync. IPC to VDA/VEA::Initialize() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: f2a9ccb5 Rebase, posciak@ comments. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/video/video_decode_accelerator.h
diff --git a/media/video/video_decode_accelerator.h b/media/video/video_decode_accelerator.h
index b7bc51152615fb367995eae12186dab8b6f9e2ed..6cef3ac17af562ef817857c1eff17d6a050b6518 100644
--- a/media/video/video_decode_accelerator.h
+++ b/media/video/video_decode_accelerator.h
@@ -8,7 +8,6 @@
#include <vector>
#include "base/basictypes.h"
-#include "base/memory/weak_ptr.h"
#include "media/base/bitstream_buffer.h"
#include "media/base/video_decoder_config.h"
#include "media/video/picture.h"
@@ -19,8 +18,7 @@ namespace media {
// Video decoder interface.
// This interface is extended by the various components that ultimately
// implement the backend of PPB_VideoDecode_Dev.
-class MEDIA_EXPORT VideoDecodeAccelerator
- : public base::SupportsWeakPtr<VideoDecodeAccelerator> {
Ami GONE FROM CHROMIUM 2014/03/17 03:17:54 \o/
+class MEDIA_EXPORT VideoDecodeAccelerator {
public:
virtual ~VideoDecodeAccelerator();
@@ -50,9 +48,6 @@ class MEDIA_EXPORT VideoDecodeAccelerator
// implements.
class MEDIA_EXPORT Client {
public:
- // Callback to notify client that decoder has been initialized.
- virtual void NotifyInitializeDone() = 0;
-
// Callback to tell client how many and what size of buffers to provide.
virtual void ProvidePictureBuffers(uint32 requested_num_of_buffers,
const gfx::Size& dimensions,
@@ -83,16 +78,16 @@ class MEDIA_EXPORT VideoDecodeAccelerator
// Video decoder functions.
- // Initializes the video decoder with specific configuration.
+ // Initializes the video decoder with specific configuration. Called once per
+ // decoder construction. This call is synchronous and returns true iff
+ // initialization is successful.
// Parameters:
// |profile| is the video stream's format profile.
// |client| is the client of this video decoder. The provided pointer must
// be valid until Destroy() is called.
- //
- // Returns true when command successfully accepted. Otherwise false.
virtual bool Initialize(VideoCodecProfile profile, Client* client) = 0;
- // Decodes given bitstream buffer that contains at most one frame. Once
+ // Decodes given bitstream buffer that contains at most one frame. Once
// decoder is done with processing |bitstream_buffer| it will call
// NotifyEndOfBitstreamBuffer() with the bitstream buffer id.
// Parameters:

Powered by Google App Engine
This is Rietveld 408576698