content/renderer/media/rtc_video_decoder.cc - Issue 185403020: Make VEA client of command buffer; move sync. IPC to VDA/VEA::Initialize()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/rtc_video_decoder.cc

Issue 185403020: Make VEA client of command buffer; move sync. IPC to VDA/VEA::Initialize() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: f2a9ccb5 Rebase, posciak@ comments. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/gpu/media/video_encode_accelerator_unittest.cc ('K') | « content/renderer/media/rtc_video_decoder.h ('k') | content/renderer/media/rtc_video_decoder_unittest.cc » ('j') | content/renderer/media/rtc_video_encoder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/rtc_video_decoder.cc

diff --git a/content/renderer/media/rtc_video_decoder.cc b/content/renderer/media/rtc_video_decoder.cc

index 0e9086fdd5fe9a11785444a14fe3ab0275056463..5195e380f0fc2c8864a90b5288810165778382d6 100644

--- a/content/renderer/media/rtc_video_decoder.cc

+++ b/content/renderer/media/rtc_video_decoder.cc

@@ -291,11 +291,6 @@ int32_t RTCVideoDecoder::Reset() {

return WEBRTC_VIDEO_CODEC_OK;

}

-void RTCVideoDecoder::NotifyInitializeDone() {

- DVLOG(2) << "NotifyInitializeDone";

- NOTREACHED();

void RTCVideoDecoder::ProvidePictureBuffers(uint32 count,

const gfx::Size& size,

uint32 texture_target) {

@@ -672,7 +667,7 @@ void RTCVideoDecoder::ReusePictureBuffer(

void RTCVideoDecoder::CreateVDA(media::VideoCodecProfile profile,

base::WaitableEvent* waiter) {

DCHECK(vda_task_runner_->BelongsToCurrentThread());

- vda_ = factories_->CreateVideoDecodeAccelerator(profile);

+ vda_ = factories_->CreateVideoDecodeAccelerator();

if (vda_ && !vda_->Initialize(profile, this))

vda_.release()->Destroy();

waiter->Signal();