content/common/gpu/media/v4l2_video_decode_accelerator.h - Issue 185403020: Make VEA client of command buffer; move sync. IPC to VDA/VEA::Initialize()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/v4l2_video_decode_accelerator.h

Issue 185403020: Make VEA client of command buffer; move sync. IPC to VDA/VEA::Initialize() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: f2a9ccb5 Rebase, posciak@ comments. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/gpu/media/gpu_video_encode_accelerator.cc ('K') | « content/common/gpu/media/gpu_video_encode_accelerator.cc ('k') | content/common/gpu/media/v4l2_video_decode_accelerator.cc » ('j') | content/common/gpu/media/vaapi_video_decode_accelerator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/media/v4l2_video_decode_accelerator.h

diff --git a/content/common/gpu/media/v4l2_video_decode_accelerator.h b/content/common/gpu/media/v4l2_video_decode_accelerator.h

index 0c6a4930714de29f9a10d33975255dc90d011f26..46eb3c4a2a43f133ad07bc8defff0cff5fa4c1c9 100644

--- a/content/common/gpu/media/v4l2_video_decode_accelerator.h

+++ b/content/common/gpu/media/v4l2_video_decode_accelerator.h

@@ -426,6 +426,9 @@ class CONTENT_EXPORT V4L2VideoDecodeAccelerator

// The codec we'll be decoding for.

media::VideoCodecProfile video_profile_;

+ // The WeakPtrFactory for |weak_this_|.

Ami GONE FROM CHROMIUM 2014/03/17 03:17:54 No point in having weak_this_ anymore, is there? (

sheu 2014/03/18 22:38:35 Careful what you wish for. It's threading all the

+ base::WeakPtrFactory<V4L2VideoDecodeAccelerator> weak_this_factory_;

DISALLOW_COPY_AND_ASSIGN(V4L2VideoDecodeAccelerator);

};