Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 18535011: Enable building for android on x86_64 machines. (Closed)

Created:
7 years, 5 months ago by rmcilroy
Modified:
7 years, 5 months ago
Reviewers:
ulan, Yang
Visibility:
Public.

Description

Enable building for android on x86_64 machines. R=ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=15702

Patch Set 1 #

Total comments: 2

Patch Set 2 : Make ANDROID_NDK_HOST_ARCH an option which can be set #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M Makefile View 1 1 chunk +1 line, -0 lines 0 comments Download
M Makefile.android View 1 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rmcilroy_google
Sorry, sent you one via the appspot rievelt server accidently (which I've just deleted). Please ...
7 years, 5 months ago (2013-07-12 14:50:32 UTC) #1
rmcilroy
ping?
7 years, 5 months ago (2013-07-16 08:48:36 UTC) #2
ulan
Sorry for the delay. https://codereview.chromium.org/18535011/diff/1/Makefile.android File Makefile.android (right): https://codereview.chromium.org/18535011/diff/1/Makefile.android#newcode39 Makefile.android:39: HOST_ARCH = $(shell uname -m ...
7 years, 5 months ago (2013-07-16 09:04:14 UTC) #3
rmcilroy
https://codereview.chromium.org/18535011/diff/1/Makefile.android File Makefile.android (right): https://codereview.chromium.org/18535011/diff/1/Makefile.android#newcode39 Makefile.android:39: HOST_ARCH = $(shell uname -m | \ On 2013/07/16 ...
7 years, 5 months ago (2013-07-16 16:44:28 UTC) #4
ulan
LGTM, I will land it for you.
7 years, 5 months ago (2013-07-17 07:59:28 UTC) #5
ulan
7 years, 5 months ago (2013-07-17 08:37:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r15702 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698