Issue 18533006: Consider conical shader opaque if it covers entire plane.

Issue 18533006: Consider conical shader opaque if it covers entire plane. (Closed)

Created:
7 years, 5 months ago by arbesfeld

Modified:
7 years, 5 months ago

Reviewers:
Stephen White, Justin Novosad, robertphillips, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Description

Consider conical shader opaque if it covers entire plane. BUG=222380 Committed: http://code.google.com/p/skia/source/detail?r=9902

Patch Set 2 : #

Created: 7 years, 5 months ago

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -4 lines)
M	src/effects/gradients/SkTwoPointConicalGradient.h	View	1 chunk	+1 line, -0 lines	0 comments
M	src/effects/gradients/SkTwoPointConicalGradient.cpp	View	2 chunks	+3 lines, -4 lines	0 comments
M	tests/GradientTest.cpp	View	2 chunks	+30 lines, -0 lines	0 comments

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Justin Novosad

https://codereview.chromium.org/18533006/diff/1/tests/GradientTest.cpp File tests/GradientTest.cpp (right): https://codereview.chromium.org/18533006/diff/1/tests/GradientTest.cpp#newcode148 tests/GradientTest.cpp:148: rec.fRadius[1], Unaligned indentation https://codereview.chromium.org/18533006/diff/1/tests/GradientTest.cpp#newcode149 tests/GradientTest.cpp:149: SkPoint::Make(rec.fPoint[1].x() + rec.fRadius[1], rec.fPoint[1].y()), ...

7 years, 5 months ago (2013-07-04 14:01:47 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/arbesfeld@chromium.org/18533006/5001

7 years, 5 months ago (2013-07-04 14:38:04 UTC) #5

robertphillips

7 years, 5 months ago (2013-07-09 13:50:41 UTC) #7

Message was sent while issue was closed.

This was reverted in r9926 due to roll issues
(https://codereview.chromium.org/18859007/)

Expand Messages | Collapse Messages