lib/src/protobuf/utils.dart - Issue 1852983002: Fix issues with protobuf equality comparisons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/protobuf/utils.dart

Issue 1852983002: Fix issues with protobuf equality comparisons (Closed) Base URL: git@github.com:dart-lang/dart-protobuf.git@master

Patch Set: tweak _deepEquals, improve tests Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/protobuf/utils.dart

diff --git a/lib/src/protobuf/utils.dart b/lib/src/protobuf/utils.dart

index 364d78f21ff96cb5261ffb871bacbed8b4823a64..6e6482bcdc104e90d5c02aa800f48271b10f0b24 100644

--- a/lib/src/protobuf/utils.dart

+++ b/lib/src/protobuf/utils.dart

@@ -6,6 +6,9 @@ part of protobuf;

// TODO(antonm): reconsider later if PbList should take care of equality.

bool _deepEquals(lhs, rhs) {

+ // Some GeneratedMessages implement Map, so test this first.

+ if (lhs is GeneratedMessage) return lhs == rhs;

+ if (rhs is GeneratedMessage) return false;

if ((lhs is List) && (rhs is List)) return _areListsEqual(lhs, rhs);

if ((lhs is Map) && (rhs is Map)) return _areMapsEqual(lhs, rhs);

if ((lhs is ByteData) && (rhs is ByteData)) {

« no previous file with comments | « lib/src/protobuf/field_set.dart ('k') | test/event_test.dart » ('j') | no next file with comments »