Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 18529004: RELAND : Reconnect support for DirectShow video capture devices in parallel to MediaFoundation ones (Closed)

Created:
7 years, 5 months ago by mcasas
Modified:
7 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Reconnect support for DirectShow video capture devices in parallel to MediaFoundation ones - UNITTESTS https://codereview.chromium.org/17402002/ broke the build - sorting out unittests for XP platforms BUG=144465 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210320

Patch Set 1 #

Patch Set 2 : corrected DS/MF api variable for tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -10 lines) Patch
M media/video/capture/video_capture_device.h View 3 chunks +39 lines, -0 lines 0 comments Download
M media/video/capture/video_capture_device_unittest.cc View 1 3 chunks +10 lines, -1 line 0 comments Download
M media/video/capture/win/video_capture_device_mf_win.h View 2 chunks +2 lines, -1 line 0 comments Download
M media/video/capture/win/video_capture_device_mf_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/video/capture/win/video_capture_device_win.cc View 4 chunks +24 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mcasas
unittests
7 years, 5 months ago (2013-07-05 15:21:18 UTC) #1
tommi (sloooow) - chröme
lgtm
7 years, 5 months ago (2013-07-05 16:27:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcasas@chromium.org/18529004/3001
7 years, 5 months ago (2013-07-05 16:27:11 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-05 19:23:32 UTC) #4
Message was sent while issue was closed.
Change committed as 210320

Powered by Google App Engine
This is Rietveld 408576698