Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 18514008: Relands test_runner.py, updates buildbot scripts (Closed)

Created:
7 years, 5 months ago by gkanwar
Modified:
7 years, 5 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Relands test_runner.py, updates buildbot scripts Relands 210035 ("Creates a new test running script test_runner.py"), and updates the buildbot scripts to point to the test_runner.py script, so the buildbots don't get deprecated warnings. BUG=248351 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210538

Patch Set 1 #

Patch Set 2 : Reintroduces test_runner.py, and adds buildbot changes to point to the new script #

Total comments: 2

Patch Set 3 : Makes content_browsertests use gtest options #

Patch Set 4 : Moves test_suite option back into gtest only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+669 lines, -486 lines) Patch
M build/android/adb_install_apk.py View 1 3 chunks +30 lines, -2 lines 0 comments Download
M build/android/buildbot/bb_device_steps.py View 5 chunks +6 lines, -6 lines 0 comments Download
M build/android/pylib/browsertests/dispatch.py View 1 4 chunks +14 lines, -5 lines 0 comments Download
M build/android/pylib/gtest/dispatch.py View 1 4 chunks +7 lines, -3 lines 0 comments Download
M build/android/pylib/gtest/test_package_apk.py View 1 3 chunks +4 lines, -3 lines 0 comments Download
M build/android/pylib/gtest/test_package_executable.py View 1 3 chunks +6 lines, -5 lines 0 comments Download
M build/android/pylib/host_driven/run_python_tests.py View 1 2 chunks +6 lines, -4 lines 0 comments Download
M build/android/pylib/instrumentation/dispatch.py View 1 3 chunks +5 lines, -4 lines 0 comments Download
M build/android/pylib/uiautomator/dispatch.py View 1 3 chunks +8 lines, -6 lines 0 comments Download
M build/android/pylib/utils/test_options_parser.py View 1 3 chunks +8 lines, -236 lines 0 comments Download
M build/android/run_browser_tests.py View 1 1 chunk +12 lines, -17 lines 0 comments Download
M build/android/run_instrumentation_tests.py View 1 1 chunk +10 lines, -64 lines 0 comments Download
M build/android/run_tests.py View 1 1 chunk +11 lines, -66 lines 0 comments Download
M build/android/run_uiautomator_tests.py View 1 1 chunk +10 lines, -65 lines 0 comments Download
A build/android/test_runner.py View 1 2 3 1 chunk +532 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
gkanwar
7 years, 5 months ago (2013-07-03 21:08:06 UTC) #1
gkanwar
7 years, 5 months ago (2013-07-08 17:15:41 UTC) #2
frankf
lgtm. Please update the description: Reverts the revert -> Reland. Also try to follow this ...
7 years, 5 months ago (2013-07-08 17:30:43 UTC) #3
frankf
On 2013/07/08 17:30:43, frankf wrote: > lgtm. > > Please update the description: Reverts the ...
7 years, 5 months ago (2013-07-08 17:31:42 UTC) #4
Isaac (away)
buildbot lgtm https://codereview.chromium.org/18514008/diff/6001/build/android/buildbot/bb_device_steps.py File build/android/buildbot/bb_device_steps.py (right): https://codereview.chromium.org/18514008/diff/6001/build/android/buildbot/bb_device_steps.py#newcode133 build/android/buildbot/bb_device_steps.py:133: RunCmd(['build/android/test_runner.py', 'content_browsertests'] + args) this is the ...
7 years, 5 months ago (2013-07-08 17:34:59 UTC) #5
gkanwar
https://codereview.chromium.org/18514008/diff/6001/build/android/buildbot/bb_device_steps.py File build/android/buildbot/bb_device_steps.py (right): https://codereview.chromium.org/18514008/diff/6001/build/android/buildbot/bb_device_steps.py#newcode133 build/android/buildbot/bb_device_steps.py:133: RunCmd(['build/android/test_runner.py', 'content_browsertests'] + args) On 2013/07/08 17:34:59, Isaac wrote: ...
7 years, 5 months ago (2013-07-08 17:43:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gkanwar@google.com/18514008/21002
7 years, 5 months ago (2013-07-09 01:04:33 UTC) #7
commit-bot: I haz the power
7 years, 5 months ago (2013-07-09 09:03:28 UTC) #8
Message was sent while issue was closed.
Change committed as 210538

Powered by Google App Engine
This is Rietveld 408576698