Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 18510005: Update tests valgrind suppressions (Closed)

Created:
7 years, 5 months ago by robertphillips
Modified:
7 years, 5 months ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Update tests valgrind suppressions Committed: http://code.google.com/p/skia/source/detail?r=9871

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M tests/valgrind.supp View 1 chunk +15 lines, -9 lines 4 comments Download

Messages

Total messages: 6 (0 generated)
robertphillips
7 years, 5 months ago (2013-07-02 17:09:39 UTC) #1
borenet
LGTM https://codereview.chromium.org/18510005/diff/1/tests/valgrind.supp File tests/valgrind.supp (left): https://codereview.chromium.org/18510005/diff/1/tests/valgrind.supp#oldcode13 tests/valgrind.supp:13: obj:/usr/lib/nvidia-current/libGL.so.280.13 Do we want to remove the nvidia ...
7 years, 5 months ago (2013-07-02 17:11:52 UTC) #2
robertphillips
https://codereview.chromium.org/18510005/diff/1/tests/valgrind.supp File tests/valgrind.supp (left): https://codereview.chromium.org/18510005/diff/1/tests/valgrind.supp#oldcode13 tests/valgrind.supp:13: obj:/usr/lib/nvidia-current/libGL.so.280.13 I think we do want to remove them ...
7 years, 5 months ago (2013-07-02 17:31:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/18510005/1
7 years, 5 months ago (2013-07-02 17:31:28 UTC) #4
borenet
On 2013/07/02 17:31:08, robertphillips wrote: > https://codereview.chromium.org/18510005/diff/1/tests/valgrind.supp > File tests/valgrind.supp (left): > > https://codereview.chromium.org/18510005/diff/1/tests/valgrind.supp#oldcode13 > ...
7 years, 5 months ago (2013-07-02 17:31:48 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-02 17:40:23 UTC) #6
Message was sent while issue was closed.
Change committed as 9871

Powered by Google App Engine
This is Rietveld 408576698