Media: Report informational error messages to HTMLMediaElement

Media: Report informational error messages to HTMLMediaElement

Caches the most recent (if any) PIPELINE_ERROR and MEDIA_ERROR_LOG_ENTRY
MediaLog events and serves their concatenation to HTMLMediaElement as an
informative media error message.

The next step will be for HTMLMediaElement to report this error message
to the devtools console upon transition into error state. Other
cumulative improvements to add such messages to MediaError for
visibility to web apps, and to clarify the WebMediaPlayer and
WebMediaPlayerClient error reporting channel will come later.

BUG=472253
Committed: https://crrev.com/4d39cc03fb3af3728b9b91134bff098f6c3d2111
Cr-Commit-Position: refs/heads/master@{#385264}

[wolenetz, 2016-04-01 02:30:43]

Patchset #1 (id:1) has been deleted

[wolenetz, 2016-04-01 02:31:00]

The CQ bit was checked by wolenetz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-01 02:32:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1850733003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1850733003/20001

[wolenetz, 2016-04-01 02:43:44]

wolenetz@chromium.org changed reviewers:
+ philipj@opera.com

[wolenetz, 2016-04-01 02:43:45]

Please take a look. This is mostly the Chromium MediaLog side of basic media
error log message caching for use via a new WebMediaPlayer::getErrorMessage()
method. Actual use of that method will come in later CL.

The idea is to allow "" from getErrorMessage() to indicate no informative error
message is yet available. For WMPI at least, there should be at least a pipeline
error string available when the networkState transitions to error, if not also a
more detailed MEDIA_LOG(ERROR) message helping web authors root-cause the
problem without having to navigate immediately to chrome://media-internals.

xhwang@: M/*, C/R/M/*
philipj@: third_party/WebKit/*
qinmin@: C/R/M/A/*
perkj@: C/R/M/{html_video_element_capturer_source_unittest.cc and
WebMediaPlayerMS changes}

To prevent spamming devtools, and to coincide with exposing the error message
via MediaError, MediaLog caches only the most recent pipeline error and media
error log entry.

Note this CL currently depends on first landing
https://codereview.chromium.org/1846913004/.

[wolenetz, 2016-04-01 02:46:16]

wolenetz@chromium.org changed reviewers:
+ perkj@chromium.org, qinmin@chromium.org, xhwang@chromium.org

[wolenetz, 2016-04-01 02:46:16]

Actually adding reviewers for realz this time. Please see msg#5 for review
request.

[commit-bot: I haz the power, 2016-04-01 02:47:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 02:48:00]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[wolenetz, 2016-04-04 18:36:20]

On 2016/04/01 02:48:00, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

Looks like the bots were unhappy. I'll rebase this onto PS4 of
https://codereview.chromium.org/1846913004/ and fix those bot errors next.

[wolenetz, 2016-04-04 20:10:08]

The CQ bit was checked by wolenetz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 20:10:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1850733003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1850733003/80001

[commit-bot: I haz the power, 2016-04-04 20:55:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 20:55:06]

Dry run: Try jobs failed on following builders:
  linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oil...)

[wolenetz, 2016-04-04 21:14:16]

The CQ bit was checked by wolenetz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 21:14:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1850733003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1850733003/100001

[wolenetz, 2016-04-04 21:44:17]

The CQ bit was checked by wolenetz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 21:45:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1850733003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1850733003/120001

[wolenetz, 2016-04-04 21:47:31]

Description was changed from

==========
Media: Report informational error messages to HTMLMediaElement

Caches the most recent (if any) PIPELINE_ERROR and MEDIA_ERROR_LOG_ENTRY
MediaLog events and serves their concatenation to HTMLMediaElement as an
informative media error message.

The next step will be for HTMLMediaElement to report this error message
to the devtools console upon transition into error state. Other
cumulative improvements to add such messages to MediaError for
visibility to web apps, and to clarify the WebMediaPlayer and
WebMediaPlayerClient error reporting channel will also come later.

BUG=472253
==========

to

==========
Media: Report informational error messages to HTMLMediaElement

Caches the most recent (if any) PIPELINE_ERROR and MEDIA_ERROR_LOG_ENTRY
MediaLog events and serves their concatenation to HTMLMediaElement as an
informative media error message.

The next step will be for HTMLMediaElement to report this error message
to the devtools console upon transition into error state. Other
cumulative improvements to add such messages to MediaError for
visibility to web apps, and to clarify the WebMediaPlayer and
WebMediaPlayerClient error reporting channel will come later.

BUG=472253
==========

[wolenetz, 2016-04-04 21:52:24]

wolenetz@chromium.org changed reviewers:
+ watk@chromium.org
- xhwang@chromium.org

[wolenetz, 2016-04-04 21:52:25]

Please review patch set 6:

This is mostly the Chromium MediaLog side of basic media
error log message caching for use via a new WebMediaPlayer::getErrorMessage()
method. Actual use of that method will come in later CL.

The idea is to allow "" from getErrorMessage() to indicate no informative error
message is yet available. For WMPI at least, there should be at least a pipeline
error string available when the networkState transitions to error, if not also a
more detailed MEDIA_LOG(ERROR) message helping web authors root-cause the
problem without having to navigate immediately to chrome://media-internals.

watk@: M/*, C/R/M/* (since xhwang@ is OoO this week)
philipj@: third_party/WebKit/*
qinmin@: C/R/M/A/*
perkj@: C/R/M/{html_video_element_capturer_source_unittest.cc and
WebMediaPlayerMS changes}

To prevent spamming devtools, and to coincide with exposing the error message
via MediaError, MediaLog caches only the most recent pipeline error and media
error log entry.

Note this CL currently depends on first landing
https://codereview.chromium.org/1846913004/ (which is in CQ right now...)

[wolenetz, 2016-04-04 23:09:34]

On 2016/04/04 21:52:25, wolenetz wrote:
> Please review patch set 6:
> 
> This is mostly the Chromium MediaLog side of basic media
> error log message caching for use via a new WebMediaPlayer::getErrorMessage()
> method. Actual use of that method will come in later CL.
> 
> The idea is to allow "" from getErrorMessage() to indicate no informative
error
> message is yet available. For WMPI at least, there should be at least a
pipeline
> error string available when the networkState transitions to error, if not also
a
> more detailed MEDIA_LOG(ERROR) message helping web authors root-cause the
> problem without having to navigate immediately to chrome://media-internals.
> 
> watk@: M/*, C/R/M/* (since xhwang@ is OoO this week)
> philipj@: third_party/WebKit/*
> qinmin@: C/R/M/A/*
> perkj@: C/R/M/{html_video_element_capturer_source_unittest.cc and
> WebMediaPlayerMS changes}
> 
> To prevent spamming devtools, and to coincide with exposing the error message
> via MediaError, MediaLog caches only the most recent pipeline error and media
> error log entry.
> 
> Note this CL currently depends on first landing
> https://codereview.chromium.org/1846913004/ (which is in CQ right now...)

Also, the next CL in this sequence of work is
https://codereview.chromium.org/1858073002/, FYI.

[commit-bot: I haz the power, 2016-04-04 23:19:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 23:19:28]

Dry run: This issue passed the CQ dry run.

[watk, 2016-04-04 23:47:25]

lgtm

https://codereview.chromium.org/1850733003/diff/120001/content/renderer/media...
File content/renderer/media/render_media_log.cc (right):

https://codereview.chromium.org/1850733003/diff/120001/content/renderer/media...
content/renderer/media/render_media_log.cc:67: // use in GetLastErrorMessage();
nit: s/;/./

https://codereview.chromium.org/1850733003/diff/120001/content/renderer/media...
content/renderer/media/render_media_log.cc:114: << (last_media_error_log_entry_
? ", " : "");
braces around multi-line statement

https://codereview.chromium.org/1850733003/diff/120001/content/renderer/media...
File content/renderer/media/render_media_log.h (right):

https://codereview.chromium.org/1850733003/diff/120001/content/renderer/media...
content/renderer/media/render_media_log.h:26: // It also caches the last error
messages to support renderer-side reporting to
s/messages/events?

https://codereview.chromium.org/1850733003/diff/120001/content/renderer/media...
content/renderer/media/render_media_log.h:58: // |last_pipeline_error_|. It
allows any render process thread to AddEvent(),
You could say lock protects access to all following member variables if this is
too annoying.

https://codereview.chromium.org/1850733003/diff/120001/media/base/media_log.cc
File media/base/media_log.cc (right):

https://codereview.chromium.org/1850733003/diff/120001/media/base/media_log.c...
media/base/media_log.cc:152: std::string MediaLog::GetLastErrorMessage() {
new line before this?

[wolenetz, 2016-04-05 00:23:27]

Thanks watk@ for review.

Others, please review patch set 7:
philipj@:third_party/WebKit/*
qinmin@:C/R/M/A/*
perkj@:C/R/M/{html_video_element_capturer_source_unittest.cc and
WebMediaPlayerMS changes}

To prevent spamming devtools, and to coincide with exposing the error message
via MediaError, MediaLog caches only the most recent pipeline error and media
error log entry.

The next CL in this sequence of work is
https://codereview.chromium.org/1858073002/.

https://codereview.chromium.org/1850733003/diff/120001/content/renderer/media...
File content/renderer/media/render_media_log.cc (right):

https://codereview.chromium.org/1850733003/diff/120001/content/renderer/media...
content/renderer/media/render_media_log.cc:67: // use in GetLastErrorMessage();
On 2016/04/04 23:47:25, watk wrote:
> nit: s/;/./

Done.

https://codereview.chromium.org/1850733003/diff/120001/content/renderer/media...
content/renderer/media/render_media_log.cc:114: << (last_media_error_log_entry_
? ", " : "");
On 2016/04/04 23:47:25, watk wrote:
> braces around multi-line statement

Argh!! git cl format strikes again :/ Done.

https://codereview.chromium.org/1850733003/diff/120001/content/renderer/media...
File content/renderer/media/render_media_log.h (right):

https://codereview.chromium.org/1850733003/diff/120001/content/renderer/media...
content/renderer/media/render_media_log.h:26: // It also caches the last error
messages to support renderer-side reporting to
On 2016/04/04 23:47:25, watk wrote:
> s/messages/events?

Done.

https://codereview.chromium.org/1850733003/diff/120001/content/renderer/media...
content/renderer/media/render_media_log.h:58: // |last_pipeline_error_|. It
allows any render process thread to AddEvent(),
On 2016/04/04 23:47:25, watk wrote:
> You could say lock protects access to all following member variables if this
is
> too annoying.

Done.

https://codereview.chromium.org/1850733003/diff/120001/media/base/media_log.cc
File media/base/media_log.cc (right):

https://codereview.chromium.org/1850733003/diff/120001/media/base/media_log.c...
media/base/media_log.cc:152: std::string MediaLog::GetLastErrorMessage() {
On 2016/04/04 23:47:25, watk wrote:
> new line before this?

Done.

[wolenetz, 2016-04-05 00:24:24]

The CQ bit was checked by wolenetz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 00:25:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1850733003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1850733003/140001

[commit-bot: I haz the power, 2016-04-05 06:26:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 06:26:51]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_TIMED_OUT,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[philipj_slow, 2016-04-05 11:25:07]

third_party/WebKit/ LGTM

[perkj_chrome, 2016-04-05 12:25:38]

Sorry - I had missed this.

webmediaplayer_ms and html_video_element_capturer_source_unittest.cc lgtm.

[qinmin, 2016-04-05 18:31:07]

lgtm

[wolenetz, 2016-04-05 18:46:41]

On 2016/04/05 18:31:07, qinmin wrote:
> lgtm

Thanks for reviews. I'll send to CQ shortly.

[wolenetz, 2016-04-05 18:46:48]

The CQ bit was checked by wolenetz@chromium.org

[wolenetz, 2016-04-05 18:46:48]

The patchset sent to the CQ was uploaded after l-g-t-m from watk@chromium.org
Link to the patchset: https://codereview.chromium.org/1850733003/#ps140001
(title: "Rebase to ToT, address watk@'s nits.")

[commit-bot: I haz the power, 2016-04-05 18:47:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1850733003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1850733003/140001

[commit-bot: I haz the power, 2016-04-05 19:54:49]

Description was changed from

==========
Media: Report informational error messages to HTMLMediaElement

Caches the most recent (if any) PIPELINE_ERROR and MEDIA_ERROR_LOG_ENTRY
MediaLog events and serves their concatenation to HTMLMediaElement as an
informative media error message.

The next step will be for HTMLMediaElement to report this error message
to the devtools console upon transition into error state. Other
cumulative improvements to add such messages to MediaError for
visibility to web apps, and to clarify the WebMediaPlayer and
WebMediaPlayerClient error reporting channel will come later.

BUG=472253
==========

to

==========
Media: Report informational error messages to HTMLMediaElement

Caches the most recent (if any) PIPELINE_ERROR and MEDIA_ERROR_LOG_ENTRY
MediaLog events and serves their concatenation to HTMLMediaElement as an
informative media error message.

The next step will be for HTMLMediaElement to report this error message
to the devtools console upon transition into error state. Other
cumulative improvements to add such messages to MediaError for
visibility to web apps, and to clarify the WebMediaPlayer and
WebMediaPlayerClient error reporting channel will come later.

BUG=472253
==========

[commit-bot: I haz the power, 2016-04-05 19:54:50]

Committed patchset #7 (id:140001)

[commit-bot: I haz the power, 2016-04-05 19:55:43]

Description was changed from

==========
Media: Report informational error messages to HTMLMediaElement

Caches the most recent (if any) PIPELINE_ERROR and MEDIA_ERROR_LOG_ENTRY
MediaLog events and serves their concatenation to HTMLMediaElement as an
informative media error message.

The next step will be for HTMLMediaElement to report this error message
to the devtools console upon transition into error state. Other
cumulative improvements to add such messages to MediaError for
visibility to web apps, and to clarify the WebMediaPlayer and
WebMediaPlayerClient error reporting channel will come later.

BUG=472253
==========

to

==========
Media: Report informational error messages to HTMLMediaElement

Caches the most recent (if any) PIPELINE_ERROR and MEDIA_ERROR_LOG_ENTRY
MediaLog events and serves their concatenation to HTMLMediaElement as an
informative media error message.

The next step will be for HTMLMediaElement to report this error message
to the devtools console upon transition into error state. Other
cumulative improvements to add such messages to MediaError for
visibility to web apps, and to clarify the WebMediaPlayer and
WebMediaPlayerClient error reporting channel will come later.

BUG=472253

Committed: https://crrev.com/4d39cc03fb3af3728b9b91134bff098f6c3d2111
Cr-Commit-Position: refs/heads/master@{#385264}
==========

[commit-bot: I haz the power, 2016-04-05 19:55:44]

Patchset 7 (id:??) landed as
https://crrev.com/4d39cc03fb3af3728b9b91134bff098f6c3d2111
Cr-Commit-Position: refs/heads/master@{#385264}