Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: base/sequence_checker_impl.cc

Issue 18501008: base: Change WeakPtr to use SequenceChecker instead of ThreadChecker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adapt to upstream changes Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/sequence_checker_impl.h" 5 #include "base/sequence_checker_impl.h"
6 6
7 #include "base/sequenced_task_runner.h" 7 #include "base/logging.h"
akalin 2013/07/11 19:31:23 still need logging.h?
tommycli 2013/07/11 21:39:13 Done.
8 8
9 namespace base { 9 namespace base {
10 10
11 SequenceCheckerImpl::SequenceCheckerImpl( 11 SequenceCheckerImpl::SequenceCheckerImpl()
12 const scoped_refptr<SequencedTaskRunner>& sequenced_task_runner) 12 : sequence_token_assigned_(false) {
13 : sequenced_task_runner_(sequenced_task_runner) {} 13 EnsureSequenceTokenAssigned();
14 }
14 15
15 SequenceCheckerImpl::~SequenceCheckerImpl() {} 16 SequenceCheckerImpl::~SequenceCheckerImpl() {}
16 17
17 bool SequenceCheckerImpl::CalledOnValidSequence() const { 18 bool SequenceCheckerImpl::CalledOnValidSequencedThread() const {
19 EnsureSequenceTokenAssigned();
18 AutoLock auto_lock(lock_); 20 AutoLock auto_lock(lock_);
19 return sequenced_task_runner_.get() ? 21
20 sequenced_task_runner_->RunsTasksOnCurrentThread() : 22 // If this thread is not associated with a SequencedWorkerPool,
21 thread_checker_.CalledOnValidThread(); 23 // SequenceChecker behaves as a ThreadChecker. See header for details.
24 if (!sequence_token_.IsValid())
25 return thread_checker_.CalledOnValidThread();
26
27 return sequence_token_.Equals(
28 SequencedWorkerPool::GetSequenceTokenForCurrentThread());
22 } 29 }
23 30
24 void SequenceCheckerImpl::ChangeSequence( 31 void SequenceCheckerImpl::DetachFromSequence() {
25 const scoped_refptr<SequencedTaskRunner>& sequenced_task_runner) {
26 AutoLock auto_lock(lock_); 32 AutoLock auto_lock(lock_);
27 sequenced_task_runner_ = sequenced_task_runner;
28 thread_checker_.DetachFromThread(); 33 thread_checker_.DetachFromThread();
34 sequence_token_assigned_ = false;
35 sequence_token_ = SequencedWorkerPool::SequenceToken();
36 }
37
38 void SequenceCheckerImpl::EnsureSequenceTokenAssigned() const {
39 AutoLock auto_lock(lock_);
40 if (sequence_token_assigned_)
41 return;
42
43 sequence_token_assigned_ = true;
44 sequence_token_ = SequencedWorkerPool::GetSequenceTokenForCurrentThread();
29 } 45 }
30 46
31 } // namespace base 47 } // namespace base
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698