Issue 18496005: Dirty line boxes when moving list marker from another block.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18496005: Dirty line boxes when moving list marker from another block. (Closed)

Created:
7 years, 5 months ago by leviw_travelin_and_unemployed

Modified:
7 years, 5 months ago

Reviewers:
xxyyzz (do-not-use), inferno, ojan, eae, eseidel

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Dirty line boxes when moving list marker from another block. RenderListItem::updateMarkerLocation can move a list marker from one block to another, but it simply called remove without dirtying the line boxes it may have been in. When the marker is being moved to another block, specifically call dirtyLinesFromChangedChild to avoid this. BUG=246205 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153532

Patch Set 1 #

Total comments: 1

Patch Set 2 : Renaming markerPar #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -6 lines)			Patch
A	LayoutTests/fast/lists/list-inside-columns-crash.html	View		1 chunk	+21 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/lists/list-inside-columns-crash-expected.txt	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/core/rendering/RenderListItem.cpp	View	1	1 chunk	+9 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

eae

LGTM with nit. https://codereview.chromium.org/18496005/diff/1/Source/core/rendering/RenderListItem.cpp File Source/core/rendering/RenderListItem.cpp (right): https://codereview.chromium.org/18496005/diff/1/Source/core/rendering/RenderListItem.cpp#newcode271 Source/core/rendering/RenderListItem.cpp:271: RenderObject* markerPar = m_marker->parent(); Could you ...

7 years, 5 months ago (2013-07-03 18:18:46 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/18496005/5001

7 years, 5 months ago (2013-07-03 18:31:15 UTC) #3

Message was sent while issue was closed.

Change committed as 153532

Expand Messages | Collapse Messages