Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1849593002:
media: Enable SRC content EncryptedMediaTest on Android (Closed)
|
Created:
4 years, 8 months ago by xhwang Modified:
4 years, 8 months ago CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionmedia: Enable SRC content EncryptedMediaTest on Android
As part of Spitzer project, now EME is supported using SRC on Android.
This also add a flag so that we'll always use unified media pipeline when
running these tests.
BUG=598964, 455905
TEST=This CL enables more tests on Android. Tested on Nexus 7 v2 with Android M.
Committed: https://crrev.com/5375fcbbcbe570f2f08c445a88aadc120ccc009a
Cr-Commit-Position: refs/heads/master@{#384498}
Patch Set 1 #
Total comments: 2
Patch Set 2 : comments addressed #
Total comments: 1
Patch Set 3 : rebase/simplify #Messages
Total messages: 16 (7 generated)
xhwang@chromium.org changed reviewers: + dalecurtis@chromium.org, ddorwin@chromium.org
PTAL
Fix "Encrytped" in the description. LGTM https://chromiumcodereview.appspot.com/1849593002/diff/1/content/browser/medi... File content/browser/media/encrypted_media_browsertest.cc (right): https://chromiumcodereview.appspot.com/1849593002/diff/1/content/browser/medi... content/browser/media/encrypted_media_browsertest.cc:53: // - bool: True to load media using MSE, otherwise use SRC. I think this was referring to .src= rather than the enum value name.
comments addressed
Description was changed from ========== media: Enable SRC EncrytpedMediaTest on Android As part of Spitzer project, now EME is supported using SRC on Android. This also add a flag so that we'll always use unified media pipeline when running these tests. BUG=598964,455905 TEST=This CL enables more tests on Android. ========== to ========== media: Enable SRC content EncryptedMediaTest on Android As part of Spitzer project, now EME is supported using SRC on Android. This also add a flag so that we'll always use unified media pipeline when running these tests. BUG=598964,455905 TEST=This CL enables more tests on Android. ==========
https://chromiumcodereview.appspot.com/1849593002/diff/1/content/browser/medi... File content/browser/media/encrypted_media_browsertest.cc (right): https://chromiumcodereview.appspot.com/1849593002/diff/1/content/browser/medi... content/browser/media/encrypted_media_browsertest.cc:53: // - bool: True to load media using MSE, otherwise use SRC. On 2016/03/30 22:13:03, ddorwin wrote: > I think this was referring to .src= rather than the enum value name. Done.
Description was changed from ========== media: Enable SRC content EncryptedMediaTest on Android As part of Spitzer project, now EME is supported using SRC on Android. This also add a flag so that we'll always use unified media pipeline when running these tests. BUG=598964,455905 TEST=This CL enables more tests on Android. ========== to ========== media: Enable SRC content EncryptedMediaTest on Android As part of Spitzer project, now EME is supported using SRC on Android. This also add a flag so that we'll always use unified media pipeline when running these tests. BUG=598964,455905 TEST=This CL enables more tests on Android. Tested on Nexus 7 v2 with Android M. ==========
https://chromiumcodereview.appspot.com/1849593002/diff/20001/content/browser/... File content/browser/media/encrypted_media_browsertest.cc (right): https://chromiumcodereview.appspot.com/1849593002/diff/20001/content/browser/... content/browser/media/encrypted_media_browsertest.cc:197: IN_PROC_BROWSER_TEST_P(EncryptedMediaTest, FrameSizeChangeVideo) { I believe this test will start failing if you do. See my change here which flips the flag: https://codereview.chromium.org/1840173004/
On 2016/03/30 22:52:07, DaleCurtis wrote: > https://chromiumcodereview.appspot.com/1849593002/diff/20001/content/browser/... > File content/browser/media/encrypted_media_browsertest.cc (right): > > https://chromiumcodereview.appspot.com/1849593002/diff/20001/content/browser/... > content/browser/media/encrypted_media_browsertest.cc:197: > IN_PROC_BROWSER_TEST_P(EncryptedMediaTest, FrameSizeChangeVideo) { > I believe this test will start failing if you do. See my change here which flips > the flag: https://codereview.chromium.org/1840173004/ Cool. I'll wait for your CL. Then we don't need to add the flag to the test.
The CQ bit was checked by xhwang@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ddorwin@chromium.org Link to the patchset: https://chromiumcodereview.appspot.com/1849593002/#ps40001 (title: "rebase/simplify")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849593002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849593002/40001
Message was sent while issue was closed.
Description was changed from ========== media: Enable SRC content EncryptedMediaTest on Android As part of Spitzer project, now EME is supported using SRC on Android. This also add a flag so that we'll always use unified media pipeline when running these tests. BUG=598964,455905 TEST=This CL enables more tests on Android. Tested on Nexus 7 v2 with Android M. ========== to ========== media: Enable SRC content EncryptedMediaTest on Android As part of Spitzer project, now EME is supported using SRC on Android. This also add a flag so that we'll always use unified media pipeline when running these tests. BUG=598964,455905 TEST=This CL enables more tests on Android. Tested on Nexus 7 v2 with Android M. ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== media: Enable SRC content EncryptedMediaTest on Android As part of Spitzer project, now EME is supported using SRC on Android. This also add a flag so that we'll always use unified media pipeline when running these tests. BUG=598964,455905 TEST=This CL enables more tests on Android. Tested on Nexus 7 v2 with Android M. ========== to ========== media: Enable SRC content EncryptedMediaTest on Android As part of Spitzer project, now EME is supported using SRC on Android. This also add a flag so that we'll always use unified media pipeline when running these tests. BUG=598964,455905 TEST=This CL enables more tests on Android. Tested on Nexus 7 v2 with Android M. Committed: https://crrev.com/5375fcbbcbe570f2f08c445a88aadc120ccc009a Cr-Commit-Position: refs/heads/master@{#384498} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/5375fcbbcbe570f2f08c445a88aadc120ccc009a Cr-Commit-Position: refs/heads/master@{#384498} |
