Issue 18466005: Allow the resource cache to (indirectly) flush the InOrderDrawBuffer

Issue 18466005: Allow the resource cache to (indirectly) flush the InOrderDrawBuffer (Closed)

Created:
7 years, 5 months ago by robertphillips

Modified:
7 years, 5 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Allow the resource cache to (indirectly) flush the InOrderDrawBuffer Committed: http://code.google.com/p/skia/source/detail?r=9949

Patch Set 1 #

Patch Set 2 : fixed comment #

Total comments: 2

Patch Set 3 : Addressed code review issues #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+100 lines, -35 lines)			Patch
M	include/gpu/GrContext.h	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	1 2	1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/gpu/GrResourceCache.h	View	1 2	2 chunks	+25 lines, -1 line	0 comments	Download
M	src/gpu/GrResourceCache.cpp	View	1 2	2 chunks	+55 lines, -34 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bsalomon

LGTM. It'll interesting to see if any benches change after this. https://codereview.chromium.org/18466005/diff/2001/src/gpu/GrResourceCache.h File src/gpu/GrResourceCache.h (right): ...

7 years, 5 months ago (2013-07-09 17:43:25 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/18466005/8001

7 years, 5 months ago (2013-07-10 10:08:00 UTC) #3

robertphillips

7 years, 5 months ago (2013-07-10 10:15:12 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/18466005/diff/2001/src/gpu/GrResourceCache.h
File src/gpu/GrResourceCache.h (right):

https://codereview.chromium.org/18466005/diff/2001/src/gpu/GrResourceCache.h#...
src/gpu/GrResourceCache.h:243: *  callback.
Done.

I expanded the comment and made the CB now return a boolean.

Expand Messages | Collapse Messages