Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 18461007: Fix two leaks & improve leak tracking (Closed)

Created:
7 years, 5 months ago by robertphillips
Modified:
7 years, 5 months ago
Reviewers:
jvanverth1, bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

The two leaks are: missing unrefs in megalooper GM missing reset capability in oval renderer This CL also expands the instance counting system to some recently adding classes (e.g., SkFontStyleSet) Committed: http://code.google.com/p/skia/source/detail?r=10030

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -3 lines) Patch
M gm/gm_expectations.h View 1 chunk +5 lines, -0 lines 0 comments Download
M gm/gm_expectations.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gm/megalooper.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M include/core/SkDocument.h View 2 chunks +4 lines, -0 lines 0 comments Download
M include/gpu/GrOvalRenderer.h View 1 chunk +5 lines, -1 line 0 comments Download
M include/lazy/SkBitmapFactory.h View 1 chunk +4 lines, -0 lines 0 comments Download
M include/lazy/SkImageCache.h View 2 chunks +5 lines, -0 lines 0 comments Download
M include/lazy/SkLruImageCache.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/lazy/SkPurgeableImageCache.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/ports/SkFontConfigInterface.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/ports/SkFontMgr.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/core/SkFontHost.cpp View 2 chunks +5 lines, -0 lines 0 comments Download
M src/doc/SkDocument.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/lazy/SkBitmapFactory.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/lazy/SkLruImageCache.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M src/lazy/SkPurgeableImageCache.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
robertphillips
7 years, 5 months ago (2013-07-11 19:22:18 UTC) #1
bsalomon
On 2013/07/11 19:22:18, robertphillips wrote: lgtm
7 years, 5 months ago (2013-07-11 19:35:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/18461007/1
7 years, 5 months ago (2013-07-11 22:22:07 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-11 22:29:39 UTC) #4
Message was sent while issue was closed.
Change committed as 10030

Powered by Google App Engine
This is Rietveld 408576698