Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 18459008: ARM Skia NEON patches - 13 - S32A_Opaque (Closed)

Created:
7 years, 5 months ago by kevin.petit.not.used.account
Modified:
7 years, 5 months ago
Reviewers:
djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

ARM Skia NEON patches - 13 - S32A_Opaque Blitrow32: S32A_Opaque code cleaning and speed improvement - the old way of calculating alpha doesn't seem to be used anymore, so remove the remaining code - adding prefetching allows to improve performance greatly in some cases at the expense of a little trade-off: +-------+-----------+------------+ | count | Cortex-A9 | Cortex-A15 | +-------+-----------+------------+ | 1,2 | 0 | 0 | +-------+-----------+------------+ | 4 | 0 | -3% | +-------+-----------+------------+ | 8 | 0 | -4% | +-------+-----------+------------+ | 16 | 0 | -5% | +-------+-----------+------------+ | 64 | +14% | 0 | +-------+-----------+------------+ | 256 | +14% | +12% | +-------+-----------+------------+ | 1024 | +115% | +15% | +-------+-----------+------------+ BUG= Committed: http://code.google.com/p/skia/source/detail?r=10026

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add the requested comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M src/opts/SkBlitRow_opts_arm_neon.cpp View 1 3 chunks +7 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
djsollen
https://codereview.chromium.org/18459008/diff/1/src/opts/SkBlitRow_opts_arm_neon.cpp File src/opts/SkBlitRow_opts_arm_neon.cpp (right): https://codereview.chromium.org/18459008/diff/1/src/opts/SkBlitRow_opts_arm_neon.cpp#newcode430 src/opts/SkBlitRow_opts_arm_neon.cpp:430: __builtin_prefetch(dst+32); can you put the comment here that this ...
7 years, 5 months ago (2013-07-11 15:24:47 UTC) #1
kevin.petit.not.used.account
https://codereview.chromium.org/18459008/diff/1/src/opts/SkBlitRow_opts_arm_neon.cpp File src/opts/SkBlitRow_opts_arm_neon.cpp (right): https://codereview.chromium.org/18459008/diff/1/src/opts/SkBlitRow_opts_arm_neon.cpp#newcode430 src/opts/SkBlitRow_opts_arm_neon.cpp:430: __builtin_prefetch(dst+32); On 2013/07/11 15:24:47, djsollen wrote: > can you ...
7 years, 5 months ago (2013-07-11 15:42:14 UTC) #2
djsollen
lgtm
7 years, 5 months ago (2013-07-11 15:43:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kevin.petit.arm@gmail.com/18459008/4001
7 years, 5 months ago (2013-07-11 15:44:01 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-07-11 20:28:33 UTC) #5
Message was sent while issue was closed.
Change committed as 10026

Powered by Google App Engine
This is Rietveld 408576698