Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 18452013: Unify Count Operation assignment with other assignments (Closed)

Created:
7 years, 5 months ago by Toon Verwaest
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Unify Count Operation assignment with other assignments This relands 15578, disables 1 test in harmony observe re bug v8:2774 R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15588

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -52 lines) Patch
M src/hydrogen.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/hydrogen.cc View 11 chunks +50 lines, -50 lines 0 comments Download
M test/mjsunit/harmony/object-observe.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
PTAL
7 years, 5 months ago (2013-07-10 09:59:07 UTC) #1
Dmitry Lomov (no reviews)
lgtm
7 years, 5 months ago (2013-07-10 12:00:36 UTC) #2
Toon Verwaest
Committed patchset #1 manually as r15588 (presubmit successful).
7 years, 5 months ago (2013-07-10 12:02:24 UTC) #3
ulan
7 years, 5 months ago (2013-07-19 08:33:52 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698