Issue 18452009: Move createClosure from V8PromiseCustom.cpp to V8Binding.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18452009: Move createClosure from V8PromiseCustom.cpp to V8Binding.h (Closed)

Created:
7 years, 5 months ago by yhirano

Modified:
7 years, 5 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, Nils Barth (inactive), jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, do-not-use

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Move createClosure from V8PromiseCustom.cpp to V8Binding.h Make the file local function public in WebCore namespace. This is a refactoring CL. BUG=243345 R=abarth Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153847

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	Source/bindings/v8/V8Binding.h	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
	M	Source/bindings/v8/custom/V8PromiseCustom.cpp	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/18452009/2001

7 years, 5 months ago (2013-07-10 02:27:15 UTC) #4

commit-bot: I haz the power

Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=12102

7 years, 5 months ago (2013-07-10 03:46:40 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/18452009/2001

7 years, 5 months ago (2013-07-10 03:50:43 UTC) #6

Message was sent while issue was closed.

Change committed as 153847

Expand Messages | Collapse Messages