Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 184493006: Rename to ChromiumTestShell package from testshell to shell (Closed)

Created:
6 years, 9 months ago by aurimas (slooooooooow)
Modified:
6 years, 9 months ago
Reviewers:
craigdh, nyquist, tonyg, pfeldman
CC:
chromium-reviews, tburkard+watch_chromium.org, browser-components-watch_chromium.org, chrome-speed-team+watch_google.com, aandrey+blink_chromium.org, Ilya Sherman, frankf+watch_chromium.org, tim+watch_chromium.org, craigdh+watch_chromium.org, vsevik, benquan, yfriedman+watch_chromium.org, devtools-reviews_chromium.org, haitaol+watch_chromium.org, cbentzel+watch_chromium.org, gavinp+prer_chromium.org, paulirish+reviews_chromium.org, bulach+watch_chromium.org, ilevy-cc_chromium.org, stgao, rouslan+autofillwatch_chromium.org, maniscalco+watch_chromium.org, davidben+watch_chromium.org, frankf, yurys, dominich+watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, klundberg+watch_chromium.org, pfeldman, telemetry+watch_chromium.org
Visibility:
Public.

Description

Rename to ChromiumTestShell package from testshell to shell Rename org.chromium.chrome.testshell to org.chromium.chrome.shell Move res/ directory to chrome/android/shell/res/ BUG=348137 TBR=pfeldman,craigdh Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254705

Patch Set 1 #

Total comments: 1

Patch Set 2 : added tonyg@ TODO #

Patch Set 3 : Rebase #

Patch Set 4 : Fix py lint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -1768 lines) Patch
M build/android/adb_gdb_chromium_testshell View 1 chunk +1 line, -1 line 0 comments Download
M build/android/adb_run_chromium_testshell View 1 chunk +1 line, -1 line 0 comments Download
M build/android/buildbot/bb_device_steps.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/gyp/apk_install.py View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M build/android/gyp/util/build_device.py View 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/pylib/constants.py View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/RepostFormWarningTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/ShortcutHelperTest.java View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderRequestTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/printing/PrintingControllerTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/search_engines/TemplateUrlServiceTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/signin/OAuth2TokenServiceIntegrationTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/sync/ChromiumSyncAdapterTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/sync/DelayedSyncControllerTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/test/DummyTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/test/ProviderBookmarkNodeTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/test/ProviderTestBase.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/translate/TranslateInfoBarTest.java View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/android/shell/res/drawable/menu_dots.png View Binary file 0 comments Download
A + chrome/android/shell/res/drawable/progress.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/shell/res/layout/testshell_activity.xml View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/android/shell/res/menu/main_menu.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/shell/res/mipmap-hdpi/app_icon.png View Binary file 0 comments Download
A + chrome/android/shell/res/mipmap-mdpi/app_icon.png View Binary file 0 comments Download
A + chrome/android/shell/res/mipmap-xhdpi/app_icon.png View Binary file 0 comments Download
A + chrome/android/shell/res/mipmap-xxhdpi/app_icon.png View Binary file 0 comments Download
A + chrome/android/shell/res/values/strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/shell/res/xml/syncadapter.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/testshell/java/AndroidManifest.xml View 5 chunks +10 lines, -10 lines 0 comments Download
A + chrome/android/testshell/java/src/org/chromium/chrome/shell/ChromiumTestShellActivity.java View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/android/testshell/java/src/org/chromium/chrome/shell/ChromiumTestShellApplication.java View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/android/testshell/java/src/org/chromium/chrome/shell/ChromiumTestShellApplicationObserver.java View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/android/testshell/java/src/org/chromium/chrome/shell/MenuHandler.java View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/android/testshell/java/src/org/chromium/chrome/shell/TabManager.java View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/android/testshell/java/src/org/chromium/chrome/shell/TestShellPKCS11AuthenticationManager.java View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/android/testshell/java/src/org/chromium/chrome/shell/TestShellTab.java View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/android/testshell/java/src/org/chromium/chrome/shell/TestShellToolbar.java View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/android/testshell/java/src/org/chromium/chrome/shell/signin/AccountsChangedReceiver.java View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/android/testshell/java/src/org/chromium/chrome/shell/sync/AccountChooserFragment.java View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/android/testshell/java/src/org/chromium/chrome/shell/sync/ChromiumTestShellSyncAdapter.java View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/android/testshell/java/src/org/chromium/chrome/shell/sync/ChromiumTestShellSyncAdapterService.java View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/android/testshell/java/src/org/chromium/chrome/shell/sync/SignoutFragment.java View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/android/testshell/java/src/org/chromium/chrome/shell/sync/SyncController.java View 1 chunk +1 line, -1 line 0 comments Download
D chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java View 1 chunk +0 lines, -307 lines 0 comments Download
D chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellApplication.java View 1 chunk +0 lines, -96 lines 0 comments Download
D chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellApplicationObserver.java View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/android/testshell/java/src/org/chromium/chrome/testshell/MenuHandler.java View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/android/testshell/java/src/org/chromium/chrome/testshell/TabManager.java View 1 chunk +0 lines, -123 lines 0 comments Download
D chrome/android/testshell/java/src/org/chromium/chrome/testshell/TestShellPKCS11AuthenticationManager.java View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/android/testshell/java/src/org/chromium/chrome/testshell/TestShellTab.java View 1 chunk +0 lines, -123 lines 0 comments Download
D chrome/android/testshell/java/src/org/chromium/chrome/testshell/TestShellToolbar.java View 1 chunk +0 lines, -159 lines 0 comments Download
D chrome/android/testshell/java/src/org/chromium/chrome/testshell/signin/AccountsChangedReceiver.java View 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/android/testshell/java/src/org/chromium/chrome/testshell/sync/AccountChooserFragment.java View 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/android/testshell/java/src/org/chromium/chrome/testshell/sync/ChromiumTestShellSyncAdapter.java View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/android/testshell/java/src/org/chromium/chrome/testshell/sync/ChromiumTestShellSyncAdapterService.java View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/android/testshell/java/src/org/chromium/chrome/testshell/sync/SignoutFragment.java View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/android/testshell/java/src/org/chromium/chrome/testshell/sync/SyncController.java View 1 chunk +0 lines, -193 lines 0 comments Download
M chrome/android/testshell/javatests/AndroidManifest.xml View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/android/testshell/javatests/src/org/chromium/chrome/shell/ChromiumTestShellTestBase.java View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/android/testshell/javatests/src/org/chromium/chrome/shell/ChromiumTestShellUrlTest.java View 1 chunk +1 line, -1 line 0 comments Download
D chrome/android/testshell/javatests/src/org/chromium/chrome/testshell/ChromiumTestShellTestBase.java View 1 chunk +0 lines, -156 lines 0 comments Download
D chrome/android/testshell/javatests/src/org/chromium/chrome/testshell/ChromiumTestShellUrlTest.java View 1 chunk +0 lines, -111 lines 0 comments Download
D chrome/android/testshell/res/drawable/menu_dots.png View Binary file 0 comments Download
D chrome/android/testshell/res/drawable/progress.xml View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/android/testshell/res/layout/testshell_activity.xml View 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/android/testshell/res/menu/main_menu.xml View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/android/testshell/res/mipmap-hdpi/app_icon.png View Binary file 0 comments Download
D chrome/android/testshell/res/mipmap-mdpi/app_icon.png View Binary file 0 comments Download
D chrome/android/testshell/res/mipmap-xhdpi/app_icon.png View Binary file 0 comments Download
D chrome/android/testshell/res/mipmap-xxhdpi/app_icon.png View Binary file 0 comments Download
D chrome/android/testshell/res/values/strings.xml View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/android/testshell/res/xml/syncadapter.xml View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/android/uiautomator_tests/src/org/chromium/chrome/testshell/uiautomator/DummyTest.java View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/devtools/devtools_adb_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_android.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/device_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/cr/cr/targets/chromium_testshell.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/docs/telemetry.core.chrome.android_browser_finder.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
aurimas (slooooooooow)
nyquist: please take a look at this change
6 years, 9 months ago (2014-03-01 00:03:22 UTC) #1
tonyg
Telemetry lgtm https://codereview.chromium.org/184493006/diff/1/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py File tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py (right): https://codereview.chromium.org/184493006/diff/1/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py#newcode27 tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py:27: 'android-chromium-testshell': Could you please add a TODO ...
6 years, 9 months ago (2014-03-01 01:11:15 UTC) #2
nyquist
lgtm
6 years, 9 months ago (2014-03-03 16:55:49 UTC) #3
aurimas (slooooooooow)
pfeldman@chromium.org: Please review changes in chrome/browser/devtools/ craigdh@chromium.org: Please review changes in build/android/buildbot/ chrome/test/chromedriver/
6 years, 9 months ago (2014-03-03 17:04:16 UTC) #4
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 9 months ago (2014-03-04 01:06:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/184493006/40001
6 years, 9 months ago (2014-03-04 01:09:09 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-04 01:31:26 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=53212
6 years, 9 months ago (2014-03-04 01:31:26 UTC) #8
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 9 months ago (2014-03-04 02:16:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/184493006/60001
6 years, 9 months ago (2014-03-04 02:17:50 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-04 07:18:06 UTC) #11
Message was sent while issue was closed. 
Change committed as 254705

Powered by Google App Engine
This is Rietveld 408576698