Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 18444002: Add setMarginStart to ApiCompatabilityUtils (Closed)

Created:
7 years, 5 months ago by Ramya
Modified:
7 years, 5 months ago
Reviewers:
Ted C, Yaron
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Add setMarginStart to ApiCompatabilityUtils This is added to handle layout margins in all Android versions. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210093

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ramya
yfriedman@ PTAL for OWNERS lgtm
7 years, 5 months ago (2013-07-02 00:41:35 UTC) #1
Ted C
lgtm
7 years, 5 months ago (2013-07-02 16:18:34 UTC) #2
Yaron
lgtm
7 years, 5 months ago (2013-07-02 17:41:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cramya@chromium.org/18444002/1
7 years, 5 months ago (2013-07-03 17:29:06 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 5 months ago (2013-07-03 20:50:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cramya@chromium.org/18444002/1
7 years, 5 months ago (2013-07-03 20:59:12 UTC) #6
commit-bot: I haz the power
7 years, 5 months ago (2013-07-04 01:27:43 UTC) #7
Message was sent while issue was closed.
Change committed as 210093

Powered by Google App Engine
This is Rietveld 408576698