Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1267)

Unified Diff: filter/count/count_test.go

Issue 1844183003: Don't filter "Stop" error in raw interface. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/gae@master
Patch Set: Count filter doesn't count Stop as error. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | filter/count/rds.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: filter/count/count_test.go
diff --git a/filter/count/count_test.go b/filter/count/count_test.go
index 2154aa85020de6efe09a69ea49b83c0cd32b26b1..191d7ef78325d29ba1d50602cac23f48af14a1aa 100644
--- a/filter/count/count_test.go
+++ b/filter/count/count_test.go
@@ -92,6 +92,15 @@ func TestCount(t *testing.T) {
So(ctr.GetMulti.Successes(), ShouldEqual, 1)
So(ctr.GetMulti.Total(), ShouldEqual, 2)
})
+
+ Convey(`datastore.Stop does not count as an error`, func() {
+ fb.BreakFeatures(datastore.Stop, "GetMulti")
+
+ So(ds.GetMulti(vals), ShouldBeNil)
+ So(ctr.GetMulti.Successes(), ShouldEqual, 1)
+ So(ctr.GetMulti.Errors(), ShouldEqual, 0)
+ So(ctr.GetMulti.Total(), ShouldEqual, 1)
+ })
})
Convey("works for memcache", t, func() {
« no previous file with comments | « no previous file | filter/count/rds.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698