Don't filter "Stop" error in raw interface.

Don't filter "Stop" error in raw interface.

The Stop error is a high-level error used by the datastore service to
indicate that an iterative operation should stop rather. It should
appear to the user as a "nil" error.

However, currently the datastore raw implementations are filtering Stop
and converting it to "nil". This prevents other filters from
identifying Stop events from their lower level callbacks.

Update raw datastore methods to not filter Stop, and update their tests
to accept Stop as a valid successful result.

BUG=

Committed: https://github.com/luci/gae/commit/2b07306ebd082f630241b64a39c20cedf29e6c20

[dnj, 2016-03-30 23:44:54]

dnj@chromium.org changed reviewers:
+ iannucci@chromium.org

[dnj, 2016-03-30 23:44:55]

PTAL

[iannucci, 2016-03-30 23:46:12]

lgtm

[dnj, 2016-03-31 00:21:51]

The CQ bit was checked by dnj@chromium.org

[dnj, 2016-03-31 00:21:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1844183003/#ps20001
(title: "Count filter doesn't count Stop as error.")

[commit-bot: I haz the power, 2016-03-31 00:22:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1844183003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1844183003/20001

[commit-bot: I haz the power, 2016-03-31 00:26:37]

Description was changed from

==========
Don't filter "Stop" error in raw interface.

The Stop error is a high-level error used by the datastore service to
indicate that an iterative operation should stop rather. It should
appear to the user as a "nil" error.

However, currently the datastore raw implementations are filtering Stop
and converting it to "nil". This prevents other filters from
identifying Stop events from their lower level callbacks.

Update raw datastore methods to not filter Stop, and update their tests
to accept Stop as a valid successful result.

BUG=
==========

to

==========
Don't filter "Stop" error in raw interface.

The Stop error is a high-level error used by the datastore service to
indicate that an iterative operation should stop rather. It should
appear to the user as a "nil" error.

However, currently the datastore raw implementations are filtering Stop
and converting it to "nil". This prevents other filters from
identifying Stop events from their lower level callbacks.

Update raw datastore methods to not filter Stop, and update their tests
to accept Stop as a valid successful result.

BUG=

Committed:
https://github.com/luci/gae/commit/2b07306ebd082f630241b64a39c20cedf29e6c20
==========

[commit-bot: I haz the power, 2016-03-31 00:26:38]

Committed patchset #2 (id:20001) as
https://github.com/luci/gae/commit/2b07306ebd082f630241b64a39c20cedf29e6c20