Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7702)

Unified Diff: chrome/chrome_tests.gypi

Issue 18419003: [chromedriver] Remove dll build target. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/all.gyp ('k') | chrome/test/chromedriver/README.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_tests.gypi
diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi
index b7815416c160d05559f9147d1a5f8dba800bb185..7c520233e5ba3494deba1a11b73ecfef06e94741 100644
--- a/chrome/chrome_tests.gypi
+++ b/chrome/chrome_tests.gypi
@@ -929,6 +929,7 @@
# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
'msvs_disabled_warnings': [ 4267, ],
},
+ # This is the new ChromeDriver based on DevTools.
{
'target_name': 'chromedriver2_lib',
'type': 'static_library',
@@ -953,14 +954,7 @@
'test/chromedriver/capabilities.h',
'test/chromedriver/chrome_launcher.cc',
'test/chromedriver/chrome_launcher.h',
- 'test/chromedriver/chromedriver.cc',
- 'test/chromedriver/chromedriver.h',
'test/chromedriver/command.h',
- 'test/chromedriver/command_executor.h',
- 'test/chromedriver/command_executor_impl.cc',
- 'test/chromedriver/command_executor_impl.h',
- 'test/chromedriver/command_names.cc',
- 'test/chromedriver/command_names.h',
'test/chromedriver/commands.cc',
'test/chromedriver/commands.h',
'test/chromedriver/element_commands.cc',
@@ -989,23 +983,6 @@
# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
'msvs_disabled_warnings': [ 4267, ],
},
- # This is the new ChromeDriver based on DevTools.
- {
- 'target_name': 'chromedriver2',
- 'type': 'loadable_module',
- 'dependencies': [
- 'chromedriver2_lib',
- '../base/base.gyp:base',
- ],
- 'include_dirs': [
- '..',
- ],
- 'sources': [
- 'test/chromedriver/chromedriver_shared_library.cc',
- ],
- # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
- 'msvs_disabled_warnings': [ 4267, ],
- },
{
'target_name': 'chromedriver2_server_lib',
'type': 'static_library',
@@ -1076,8 +1053,6 @@
'test/chromedriver/chrome/stub_web_view.h',
'test/chromedriver/chrome/web_view_impl_unittest.cc',
'test/chromedriver/chrome_launcher_unittest.cc',
- 'test/chromedriver/chromedriver_unittest.cc',
- 'test/chromedriver/command_executor_impl_unittest.cc',
'test/chromedriver/commands_unittest.cc',
'test/chromedriver/fake_session_accessor.cc',
'test/chromedriver/fake_session_accessor.h',
« no previous file with comments | « build/all.gyp ('k') | chrome/test/chromedriver/README.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698