[chromedriver] Remove dll build target.

[chromedriver] Remove dll build  target.
Remove files once used to build chromedriver dll.
Remove CommandExecutor and CommandNames.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209801

[chrisgao (Use stgao instead), 2013-07-02 01:31:40]

https://codereview.chromium.org/18419003/diff/2001/chrome/test/chromedriver/s...
File chrome/test/chromedriver/server/http_handler.cc (right):

https://codereview.chromium.org/18419003/diff/2001/chrome/test/chromedriver/s...
chrome/test/chromedriver/server/http_handler.cc:62:
CommandMapping::CommandMapping() {}
remove

https://codereview.chromium.org/18419003/diff/2001/chrome/test/chromedriver/s...
chrome/test/chromedriver/server/http_handler.cc:145:
base::Bind(&UnimplementedCommand)),
Remove unimplemented command mappings or add a stub?

https://codereview.chromium.org/18419003/diff/2001/chrome/test/chromedriver/s...
File chrome/test/chromedriver/server/http_handler.h (right):

https://codereview.chromium.org/18419003/diff/2001/chrome/test/chromedriver/s...
chrome/test/chromedriver/server/http_handler.h:50: CommandMapping();
remove

[kkania, 2013-07-02 01:57:08]

lgtm

https://codereview.chromium.org/18419003/diff/2001/chrome/test/chromedriver/R...
File chrome/test/chromedriver/README.txt (right):

https://codereview.chromium.org/18419003/diff/2001/chrome/test/chromedriver/R...
chrome/test/chromedriver/README.txt:14: $ export
PYTHONPATH=<CHROMEDRIVER_SRC_DIR>/server:<CHROMEDRIVER_SRC_DIR>/client
export PYTHONPATH=<THIS_DIR>/server:<THIS_DIR>/client

https://codereview.chromium.org/18419003/diff/2001/chrome/test/chromedriver/R...
chrome/test/chromedriver/README.txt:38: When a new session is created, a new
thread is started and it dedicates to the
is started that is dedicated to the session.

https://codereview.chromium.org/18419003/diff/2001/chrome/test/chromedriver/R...
chrome/test/chromedriver/README.txt:69: An extension used for commands related
to window size or position.
just say its an extension used for automating the desktop browser

https://codereview.chromium.org/18419003/diff/2001/chrome/test/chromedriver/s...
File chrome/test/chromedriver/server/http_handler.cc (right):

https://codereview.chromium.org/18419003/diff/2001/chrome/test/chromedriver/s...
chrome/test/chromedriver/server/http_handler.cc:118:
WrapToNonSessionCommand(base::Bind(&ExecuteGetAlertText))),
alert stuff should use ExecuteAlertCommand

https://codereview.chromium.org/18419003/diff/2001/chrome/test/chromedriver/s...
chrome/test/chromedriver/server/http_handler.cc:375: this->command_map_ =
scoped_ptr<CommandMap>(
command_map_.reset(new CommandMap(commands, commands + arraysize(commands));

https://codereview.chromium.org/18419003/diff/2001/chrome/test/chromedriver/s...
chrome/test/chromedriver/server/http_handler.cc:406: Command
HttpHandler::WrapToNonSessionCommand(
How about just call these WrapToCommand?

https://codereview.chromium.org/18419003/diff/2001/chrome/test/chromedriver/s...
File chrome/test/chromedriver/server/http_handler.h (right):

https://codereview.chromium.org/18419003/diff/2001/chrome/test/chromedriver/s...
chrome/test/chromedriver/server/http_handler.h:66: void Init();
can we remove the init and just do in the constructor?

[chrisgao (Use stgao instead), 2013-07-02 18:13:04]

https://codereview.chromium.org/18419003/diff/2001/chrome/test/chromedriver/R...
File chrome/test/chromedriver/README.txt (right):

https://codereview.chromium.org/18419003/diff/2001/chrome/test/chromedriver/R...
chrome/test/chromedriver/README.txt:14: $ export
PYTHONPATH=<CHROMEDRIVER_SRC_DIR>/server:<CHROMEDRIVER_SRC_DIR>/client
On 2013/07/02 01:57:08, kkania wrote:
> export PYTHONPATH=<THIS_DIR>/server:<THIS_DIR>/client

Done.

https://codereview.chromium.org/18419003/diff/2001/chrome/test/chromedriver/R...
chrome/test/chromedriver/README.txt:38: When a new session is created, a new
thread is started and it dedicates to the
On 2013/07/02 01:57:08, kkania wrote:
> is started that is dedicated to the session.

Done.

https://codereview.chromium.org/18419003/diff/2001/chrome/test/chromedriver/R...
chrome/test/chromedriver/README.txt:69: An extension used for commands related
to window size or position.
On 2013/07/02 01:57:08, kkania wrote:
> just say its an extension used for automating the desktop browser

Done.

https://codereview.chromium.org/18419003/diff/2001/chrome/test/chromedriver/s...
File chrome/test/chromedriver/server/http_handler.cc (right):

https://codereview.chromium.org/18419003/diff/2001/chrome/test/chromedriver/s...
chrome/test/chromedriver/server/http_handler.cc:62:
CommandMapping::CommandMapping() {}
On 2013/07/02 01:31:40, chrisgao wrote:
> remove

Done.

https://codereview.chromium.org/18419003/diff/2001/chrome/test/chromedriver/s...
chrome/test/chromedriver/server/http_handler.cc:118:
WrapToNonSessionCommand(base::Bind(&ExecuteGetAlertText))),
On 2013/07/02 01:57:08, kkania wrote:
> alert stuff should use ExecuteAlertCommand

Done.

https://codereview.chromium.org/18419003/diff/2001/chrome/test/chromedriver/s...
chrome/test/chromedriver/server/http_handler.cc:145:
base::Bind(&UnimplementedCommand)),
On 2013/07/02 01:31:40, chrisgao wrote:
> Remove unimplemented command mappings or add a stub?

Done.

https://codereview.chromium.org/18419003/diff/2001/chrome/test/chromedriver/s...
chrome/test/chromedriver/server/http_handler.cc:375: this->command_map_ =
scoped_ptr<CommandMap>(
On 2013/07/02 01:57:08, kkania wrote:
> command_map_.reset(new CommandMap(commands, commands + arraysize(commands));

Done.

https://codereview.chromium.org/18419003/diff/2001/chrome/test/chromedriver/s...
chrome/test/chromedriver/server/http_handler.cc:406: Command
HttpHandler::WrapToNonSessionCommand(
On 2013/07/02 01:57:08, kkania wrote:
> How about just call these WrapToCommand?

Done.

https://codereview.chromium.org/18419003/diff/2001/chrome/test/chromedriver/s...
File chrome/test/chromedriver/server/http_handler.h (right):

https://codereview.chromium.org/18419003/diff/2001/chrome/test/chromedriver/s...
chrome/test/chromedriver/server/http_handler.h:50: CommandMapping();
On 2013/07/02 01:31:40, chrisgao wrote:
> remove

Done.

https://codereview.chromium.org/18419003/diff/2001/chrome/test/chromedriver/s...
chrome/test/chromedriver/server/http_handler.h:66: void Init();
On 2013/07/02 01:57:08, kkania wrote:
> can we remove the init and just do in the constructor?

Done.

[commit-bot: I haz the power, 2013-07-02 18:38:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/chrisgao@chromium.org/18419003/14001

[commit-bot: I haz the power, 2013-07-02 22:36:59]

Change committed as 209801