Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18414008: Reland r210741 "Separate DemuxerStream and VideoDecoder." (Closed)

Created:
7 years, 5 months ago by xhwang
Modified:
7 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Reland r210741 "Separate DemuxerStream and VideoDecoder." The original CL r210741 was reverted by r210765 due to a test failure. This CL relands r210741 with the fix. BUG=141788 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211559

Patch Set 1 #

Patch Set 2 : Fix the crash found by VRBTest. #

Total comments: 1

Patch Set 3 : rebase only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+693 lines, -1009 lines) Patch
M media/base/mock_filters.h View 2 chunks +4 lines, -3 lines 0 comments Download
M media/base/test_helpers.h View 2 chunks +13 lines, -0 lines 0 comments Download
M media/base/test_helpers.cc View 2 chunks +38 lines, -0 lines 0 comments Download
M media/base/video_decoder.h View 2 chunks +19 lines, -19 lines 0 comments Download
M media/filters/decrypting_demuxer_stream.h View 2 chunks +4 lines, -6 lines 0 comments Download
M media/filters/decrypting_video_decoder.h View 5 chunks +6 lines, -13 lines 0 comments Download
M media/filters/decrypting_video_decoder.cc View 10 chunks +16 lines, -59 lines 0 comments Download
M media/filters/decrypting_video_decoder_unittest.cc View 13 chunks +29 lines, -103 lines 0 comments Download
M media/filters/fake_demuxer_stream.h View 2 chunks +1 line, -2 lines 0 comments Download
M media/filters/fake_demuxer_stream.cc View 3 chunks +3 lines, -13 lines 0 comments Download
M media/filters/fake_video_decoder.h View 4 chunks +4 lines, -14 lines 0 comments Download
M media/filters/fake_video_decoder.cc View 6 chunks +28 lines, -84 lines 0 comments Download
M media/filters/fake_video_decoder_unittest.cc View 10 chunks +101 lines, -127 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.h View 4 chunks +7 lines, -12 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 11 chunks +14 lines, -66 lines 0 comments Download
M media/filters/ffmpeg_video_decoder_unittest.cc View 11 chunks +104 lines, -166 lines 0 comments Download
M media/filters/gpu_video_decoder.h View 5 chunks +5 lines, -13 lines 0 comments Download
M media/filters/gpu_video_decoder.cc View 21 chunks +50 lines, -91 lines 0 comments Download
M media/filters/video_decoder_selector.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/video_frame_stream.h View 5 chunks +23 lines, -14 lines 0 comments Download
M media/filters/video_frame_stream.cc View 1 10 chunks +141 lines, -96 lines 0 comments Download
M media/filters/video_frame_stream_unittest.cc View 1 2 6 chunks +23 lines, -5 lines 0 comments Download
M media/filters/video_renderer_base_unittest.cc View 6 chunks +11 lines, -4 lines 0 comments Download
M media/filters/vpx_video_decoder.h View 4 chunks +8 lines, -13 lines 0 comments Download
M media/filters/vpx_video_decoder.cc View 10 chunks +34 lines, -79 lines 0 comments Download
M media/media.gyp View 1 2 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
xhwang
Patch set (PS) 1 is the original CL. PS2 has the fix to the crash. ...
7 years, 5 months ago (2013-07-12 23:38:20 UTC) #1
scherkus (not reviewing)
lgtm https://codereview.chromium.org/18414008/diff/2001/media/filters/video_frame_stream.cc File media/filters/video_frame_stream.cc (right): https://codereview.chromium.org/18414008/diff/2001/media/filters/video_frame_stream.cc#newcode73 media/filters/video_frame_stream.cc:73: read_cb_ = read_cb; wow! nice find!
7 years, 5 months ago (2013-07-13 01:13:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/18414008/8001
7 years, 5 months ago (2013-07-13 01:49:20 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-13 04:22:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/18414008/8001
7 years, 5 months ago (2013-07-13 04:51:07 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-13 09:45:28 UTC) #6
Message was sent while issue was closed. 
Change committed as 211559

Powered by Google App Engine
This is Rietveld 408576698