Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: content/browser/renderer_host/render_widget_host_impl.h

Issue 18413004: Fix false positive/negative resize_ack_pending_ in RenderWidgetHostImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <list> 9 #include <list>
10 #include <map> 10 #include <map>
(...skipping 778 matching lines...) Expand 10 before | Expand all | Expand 10 after
789 789
790 // The height of the physical backing surface that is overdrawn opaquely in 790 // The height of the physical backing surface that is overdrawn opaquely in
791 // the browser, for example by an on-screen-keyboard (in DPI-adjusted pixels). 791 // the browser, for example by an on-screen-keyboard (in DPI-adjusted pixels).
792 float overdraw_bottom_height_; 792 float overdraw_bottom_height_;
793 793
794 // The size we last sent as requested size to the renderer. |current_size_| 794 // The size we last sent as requested size to the renderer. |current_size_|
795 // is only updated once the resize message has been ack'd. This on the other 795 // is only updated once the resize message has been ack'd. This on the other
796 // hand is updated when the resize message is sent. This is very similar to 796 // hand is updated when the resize message is sent. This is very similar to
797 // |resize_ack_pending_|, but the latter is not set if the new size has width 797 // |resize_ack_pending_|, but the latter is not set if the new size has width
798 // or height zero, which is why we need this too. 798 // or height zero, which is why we need this too.
799 gfx::Size in_flight_size_; 799 gfx::Size last_requested_size_;
800 800
801 // The next auto resize to send. 801 // The next auto resize to send.
802 gfx::Size new_auto_size_; 802 gfx::Size new_auto_size_;
803 803
804 // True if the render widget host should track the render widget's size as 804 // True if the render widget host should track the render widget's size as
805 // opposed to visa versa. 805 // opposed to visa versa.
806 bool should_auto_resize_; 806 bool should_auto_resize_;
807 807
808 bool waiting_for_screen_rects_ack_; 808 bool waiting_for_screen_rects_ack_;
809 gfx::Rect last_view_screen_rect_; 809 gfx::Rect last_view_screen_rect_;
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
955 int64 last_input_number_; 955 int64 last_input_number_;
956 956
957 BrowserRenderingStats rendering_stats_; 957 BrowserRenderingStats rendering_stats_;
958 958
959 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostImpl); 959 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostImpl);
960 }; 960 };
961 961
962 } // namespace content 962 } // namespace content
963 963
964 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_ 964 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698