Fix GenerateDiff -- don't strip whitespace.

Fix GenerateDiff -- don't strip whitespace.

BUG=259434
R=iannucci

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=211483

[commit-bot: I haz the power, 2013-07-12 22:45:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ilevy@chromium.org/18408006/1

[iannucci, 2013-07-12 22:49:08]

https://chromiumcodereview.appspot.com/18408006/diff/1/scm.py
File scm.py (right):

https://chromiumcodereview.appspot.com/18408006/diff/1/scm.py#newcode104
scm.py:104: no_strip = kwargs.pop('no_strip', None)
"I'm gonna pop some kwargs -- only got 20 vars in my namespace..."

Seriously though, I would just add this as a named argument (no_strip=None) to
the function.

May want to make it neutral too... strip=False

https://chromiumcodereview.appspot.com/18408006/diff/1/scm.py#newcode111
scm.py:111: return output.strip()
return output if no_strip else output.strip()

[Isaac (away), 2013-07-12 23:19:41]

https://chromiumcodereview.appspot.com/18408006/diff/1/scm.py
File scm.py (right):

https://chromiumcodereview.appspot.com/18408006/diff/1/scm.py#newcode104
scm.py:104: no_strip = kwargs.pop('no_strip', None)
On 2013/07/12 22:49:08, iannucci wrote:
> "I'm gonna pop some kwargs -- only got 20 vars in my namespace..."
> 
> Seriously though, I would just add this as a named argument (no_strip=None) to
> the function.
> 
> May want to make it neutral too... strip=False

Done -- named it strip_out

https://chromiumcodereview.appspot.com/18408006/diff/1/scm.py#newcode111
scm.py:111: return output.strip()
On 2013/07/12 22:49:08, iannucci wrote:
> return output if no_strip else output.strip()

Done.

[iannucci, 2013-07-12 23:22:17]

deliciouslgtm

[commit-bot: I haz the power, 2013-07-12 23:36:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ilevy@chromium.org/18408006/6001

[commit-bot: I haz the power, 2013-07-12 23:38:42]

Change committed as 211483