Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 1840563002: Revert of media: Enable Unified Media Pipeline for MSE and EME on Android (Closed)

Created:
4 years, 9 months ago by gone
Modified:
4 years, 9 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gavinp+loader_chromium.org, gasubic, jam, Nate Chapin, loading-reviews_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-blink_chromium.org, nasko+codewatch_chromium.org, philipj_slow, sandersd (OOO until July 31), nessy, Tima Vaisburd, tyoshino+watch_chromium.org, vcarbune.chromium, wolenetz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of media: Enable Unified Media Pipeline for MSE and EME on Android (patchset #3 id:40001 of https://chromiumcodereview.appspot.com/1825763002/ ) Reason for revert: Android tests on many bots started failing right after this; these are the most obvious: https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester/builds/3714 * RenderFrameImplTest.LoFiNotUpdatedOnSubframeCommits * RenderViewImplTest.OnSetAccessibilityMode I reverted locally multiple times to make sure, but RenderFrameImplTest.LoFiNotUpdatedOnSubframeCommits only starts failing when this CL is committed, AFAICT. Original issue's description: > media: Enable Unified Media Pipeline for MSE and EME on Android > > Enables Mojo Media on Android to support EME in the unified media > pipeline. This introduces MojoCdm, MojoAudioDecoder and encrytped > stream support in AndroidVideoDecodeAccelerator. > > This CL also enables MSE in the unified media pipeline. The fallback > logic for MSE (IsUnifiedMediaPipelineEnabledForMse()) is removed. > > Also partially reverts f92f4e5c849c028db73fbe06912685a77b978ee4 which > added "LoadType" in createMediaPlayer() to implement the fallback > logic for MSE. > > BUG=455905, 521731 > TEST=Encrypted audio/video plays in default Chrome for Android build > with and without unified media pipeline. > > Committed: https://crrev.com/92d0fffc36695c099005bf05862145a89d918f28 > Cr-Commit-Position: refs/heads/master@{#383331} TBR=dalecurtis@chromium.org,ddorwin@chromium.org,timav@chromium.org,wolenetz@chromium.org,pfeldman@chromium.org,xhwang@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=455905, 521731 Committed: https://crrev.com/e0eeb14423a840cfaec05a0218897c3bf35a4548 Cr-Commit-Position: refs/heads/master@{#383409}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -56 lines) Patch
M content/renderer/render_frame_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 7 chunks +28 lines, -40 lines 0 comments Download
M media/base/media.h View 1 chunk +6 lines, -0 lines 0 comments Download
M media/base/media.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M media/filters/stream_parser_factory.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M media/media_options.gni View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoaderClient.h View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 3 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
gone
Created Revert of media: Enable Unified Media Pipeline for MSE and EME on Android
4 years, 9 months ago (2016-03-25 23:43:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840563002/1
4 years, 9 months ago (2016-03-25 23:45:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-25 23:45:54 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 23:47:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0eeb14423a840cfaec05a0218897c3bf35a4548
Cr-Commit-Position: refs/heads/master@{#383409}

Powered by Google App Engine
This is Rietveld 408576698