Tease apart ServiceWorkerNetworkProvider from other stuff.

content/child/service_worker/service_worker_network_provider.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_CHILD_SERVICE_WORKER_SERVICE_WORKER_NETWORK_PROVIDER_IMPL_H_
+#define CONTENT_CHILD_SERVICE_WORKER_SERVICE_WORKER_NETWORK_PROVIDER_IMPL_H_
+
+#include "base/compiler_specific.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/supports_user_data.h"
+
+namespace content {
+
+// A unique provider_id is generated for each instance.
+// Instanced prior to the main resource load being started and remains

[Charlie Reis, 2014/03/04 23:02:17]

Instantiated
(Sorry, I had trouble reading this with the previous sentence ending in
instance.)

[michaeln, 2014/03/04 23:53:46]

Done.

+// allocated until after the last subresoure load has occured.

[Charlie Reis, 2014/03/04 23:02:17]

subresource, occurred

[michaeln, 2014/03/04 23:53:46]

Done.

+// This is used to track the lifetime of a Document to create
+// and dispose the ServiceWorkerProviderHost in the browser process

[Charlie Reis, 2014/03/04 23:02:17]

Presumably the browser process also disposes of the host if this child process
dies, right?  (No change needed here; just wanted to sanity check.)

[michaeln, 2014/03/04 23:53:46]

oh, we hadn't thought of that ;)

JK, yes, cleanup happens by way of that form of exit too. This is the basis for
how we know which serviceworkers are in use and such.

+// to match its lifetime. Each request coming from the Document is
+// tagged with this id in willSendRequest.
+// tl;dr
+// Its a scoped integer that sends an ipc upon ctor'tion and dtor'tion.

[Charlie Reis, 2014/03/04 23:02:17]

It's

Also, you might say either "via ctor/dtor" or "upon construction and deletion,"
since it currently reads like "upon contortion and distortion."  :)

[michaeln, 2014/03/04 23:53:46]

Done (but... i kinda liked that pun)

+class ServiceWorkerNetworkProvider : public base::SupportsUserData::Data {
+ public:
+  // Ownership is trasferred to the DocumentState.

[Charlie Reis, 2014/03/04 23:02:17]

transferred

[michaeln, 2014/03/04 23:53:46]

Done.

+  static void AttachToDocumentState(
+      base::SupportsUserData* document_state,
+      scoped_ptr<ServiceWorkerNetworkProvider> network_provider);
+
+  static ServiceWorkerNetworkProvider* FromDocumentState(
+      base::SupportsUserData* document_state);
+
+  ServiceWorkerNetworkProvider();
+  virtual ~ServiceWorkerNetworkProvider();
+
+  int provider_id() const { return provider_id_; }
+
+ private:
+  const int provider_id_;
+  DISALLOW_COPY_AND_ASSIGN(ServiceWorkerNetworkProvider);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_CHILD_SERVICE_WORKER_WEB_SERVICE_WORKER_PROVIDER_IMPL_H_