Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: Source/bindings/v8/V8ThrowException.cpp

Issue 18398002: Remove IDBNotFoundError ExceptionCode (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add missing include in code gen wich causes win compile failure Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/V8ThrowException.cpp
diff --git a/Source/bindings/v8/V8ThrowException.cpp b/Source/bindings/v8/V8ThrowException.cpp
index e6a532cb1003caa7bae3f072f9121784f4462369..bb1c9089a8179d2fb9b2e85da57462a8eb02bd3f 100644
--- a/Source/bindings/v8/V8ThrowException.cpp
+++ b/Source/bindings/v8/V8ThrowException.cpp
@@ -44,16 +44,16 @@ static void domExceptionStackSetter(v8::Local<v8::String> name, v8::Local<v8::Va
info.Data()->ToObject()->Set(v8::String::NewSymbol("stack"), value);
}
-v8::Handle<v8::Value> V8ThrowException::setDOMException(int ec, v8::Isolate* isolate)
+v8::Handle<v8::Value> V8ThrowException::setDOMException(int ec, const char* message, v8::Isolate* isolate)
{
if (ec <= 0 || v8::V8::IsExecutionTerminating())
return v8Undefined();
// FIXME: Handle other WebIDL exception types.
if (ec == TypeError)
- return V8ThrowException::throwTypeError(0, isolate);
+ return V8ThrowException::throwTypeError(message, isolate);
- RefPtr<DOMException> domException = DOMException::create(ec);
+ RefPtr<DOMException> domException = DOMException::create(ec, message);
v8::Handle<v8::Value> exception = toV8(domException, v8::Handle<v8::Object>(), isolate);
if (exception.IsEmpty())

Powered by Google App Engine
This is Rietveld 408576698