Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Side by Side Diff: Source/core/editing/ReplaceNodeWithSpanCommand.cpp

Issue 18398002: Remove IDBNotFoundError ExceptionCode (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2009 Google Inc. All rights reserved. 2 * Copyright (c) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 parentNode->insertBefore(newNode, nodeToReplace, ASSERT_NO_EXCEPTION); 55 parentNode->insertBefore(newNode, nodeToReplace, ASSERT_NO_EXCEPTION);
56 56
57 NodeVector children; 57 NodeVector children;
58 getChildNodes(nodeToReplace, children); 58 getChildNodes(nodeToReplace, children);
59 for (size_t i = 0; i < children.size(); ++i) 59 for (size_t i = 0; i < children.size(); ++i)
60 newNode->appendChild(children[i], ASSERT_NO_EXCEPTION); 60 newNode->appendChild(children[i], ASSERT_NO_EXCEPTION);
61 61
62 // FIXME: Fix this to send the proper MutationRecords when MutationObservers are present. 62 // FIXME: Fix this to send the proper MutationRecords when MutationObservers are present.
63 newNode->cloneDataFromElement(*nodeToReplace); 63 newNode->cloneDataFromElement(*nodeToReplace);
64 64
65 parentNode->removeChild(nodeToReplace, ASSERT_NO_EXCEPTION); 65 parentNode->removeChild(nodeToReplace);
Mike West 2013/07/10 09:40:30 Why did you drop the ASSERT_NO_EXCEPTION here and
arv (Not doing code reviews) 2013/07/10 15:37:24 These are useless since it defaults to ASSERT_NO_E
66 } 66 }
67 67
68 void ReplaceNodeWithSpanCommand::doApply() 68 void ReplaceNodeWithSpanCommand::doApply()
69 { 69 {
70 if (!m_elementToReplace->inDocument()) 70 if (!m_elementToReplace->inDocument())
71 return; 71 return;
72 if (!m_spanElement) 72 if (!m_spanElement)
73 m_spanElement = createHTMLElement(m_elementToReplace->document(), spanTa g); 73 m_spanElement = createHTMLElement(m_elementToReplace->document(), spanTa g);
74 swapInNodePreservingAttributesAndChildren(m_spanElement.get(), m_elementToRe place.get()); 74 swapInNodePreservingAttributesAndChildren(m_spanElement.get(), m_elementToRe place.get());
75 } 75 }
76 76
77 void ReplaceNodeWithSpanCommand::doUnapply() 77 void ReplaceNodeWithSpanCommand::doUnapply()
78 { 78 {
79 if (!m_spanElement->inDocument()) 79 if (!m_spanElement->inDocument())
80 return; 80 return;
81 swapInNodePreservingAttributesAndChildren(m_elementToReplace.get(), m_spanEl ement.get()); 81 swapInNodePreservingAttributesAndChildren(m_elementToReplace.get(), m_spanEl ement.get());
82 } 82 }
83 83
84 #ifndef NDEBUG 84 #ifndef NDEBUG
85 void ReplaceNodeWithSpanCommand::getNodesInCommand(HashSet<Node*>& nodes) 85 void ReplaceNodeWithSpanCommand::getNodesInCommand(HashSet<Node*>& nodes)
86 { 86 {
87 addNodeAndDescendants(m_elementToReplace.get(), nodes); 87 addNodeAndDescendants(m_elementToReplace.get(), nodes);
88 addNodeAndDescendants(m_spanElement.get(), nodes); 88 addNodeAndDescendants(m_spanElement.get(), nodes);
89 } 89 }
90 #endif 90 #endif
91 91
92 } // namespace WebCore 92 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698