POSIX: CHECK() that file_util::ScopedFD fulfills promise.

base/file_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #include <shellapi.h>
 #include <shlobj.h>
 #include <tchar.h>
 #include <winioctl.h>
 #endif
 
+#if defined(OS_POSIX)
+#include <errno.h>
+#include <fcntl.h>
+#include <unistd.h>
+#endif
+
 #include <algorithm>
 #include <fstream>
 #include <set>
 
 #include "base/base_paths.h"
 #include "base/file_util.h"
 #include "base/files/file_enumerator.h"
 #include "base/files/file_path.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/path_service.h"
@@ skipping 2431 matching lines @@
   // Size should be smaller than 0.
   int64 size;
   EXPECT_FALSE(GetFileSize(path, &size));
 
   // We should not be able to read the file.
   int fd = OpenContentUriForRead(path);
   EXPECT_EQ(-1, fd);
 }
 #endif
 
+TEST(ScopedFD, ScopedFDDoesClose) {
+  int fds[2];
+  char c = 0;
+  ASSERT_EQ(0, pipe(fds));
+  const int write_end = fds[1];
+  file_util::ScopedFDCloser read_end_closer(fds);
+  {
+    file_util::ScopedFDCloser write_end_closer(fds + 1);
+  }
+  // This is the only thread. This file descriptor should no longer be valid.
+  int ret = close(write_end);
+  EXPECT_EQ(-1, ret);
+  EXPECT_EQ(EBADF, errno);
+  // Make sure read(2) won't block.
+  ASSERT_EQ(0, fcntl(fds[0], F_SETFL, O_NONBLOCK));
+  // Reading the pipe should EOF.
+  EXPECT_EQ(0, read(fds[0], &c, 1));
+}
+
+void CloseWithScopedFD(int fd) {
+  file_util::ScopedFDCloser fd_closer(&fd);
+}
+
+TEST(ScopedFD, ScopedFDCrashesOnCloseFailure) {
+  int fds[2];
+  ASSERT_EQ(0, pipe(fds));
+  file_util::ScopedFDCloser read_end_closer(fds);
+  CHECK_EQ(0, IGNORE_EINTR(close(fds[1])));

[willchan no longer on Chromium, 2014/02/28 01:48:48]

Shouldn't this be EXPECT_EQ? Is there an advantage to crashing the test suite
when this fails?

[jln (very slow on Chromium), 2014/02/28 02:01:21]

You're right, a fd leak is probably not worth a crash. Done.

+#if defined(GTEST_HAS_DEATH_TEST)
+  // This is the only thread. This file descriptor should no longer be valid.
+  // Trying to close it should crash. This is important for security.
+  EXPECT_DEATH(CloseWithScopedFD(fds[1]), "");
+#endif
+}
+
 #endif  // defined(OS_POSIX)
 
 }  // namespace
 
 }  // namespace base