Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1839023002: Cache user agent string in FrameLoaderClientImpl instead of BlinkPlatformImpl (Closed)

Created:
4 years, 8 months ago by hajimehoshi
Modified:
4 years, 8 months ago
CC:
blink-reviews, chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cache user agent string in FrameLoaderClientImpl instead of BlinkPlatformImpl This CL makes FrameLoaderClientImpl cache user agent string instead of BlinkPlatformImpl to avoid threading issue. BUG=598479 Committed: https://crrev.com/40696fd9bf6a11db52416ccf98f129e72df47f73 Cr-Commit-Position: refs/heads/master@{#383915}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M content/child/blink_platform_impl.cc View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
hajimehoshi
PTAL
4 years, 8 months ago (2016-03-29 10:04:36 UTC) #2
kouhei (in TOK)
+tzik
4 years, 8 months ago (2016-03-29 10:30:35 UTC) #4
tzik
lgtm
4 years, 8 months ago (2016-03-29 12:27:06 UTC) #5
esprehn
lgtm
4 years, 8 months ago (2016-03-29 21:33:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839023002/1
4 years, 8 months ago (2016-03-30 04:40:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 05:40:13 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 05:41:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/40696fd9bf6a11db52416ccf98f129e72df47f73
Cr-Commit-Position: refs/heads/master@{#383915}

Powered by Google App Engine
This is Rietveld 408576698