Source/core/rendering/RenderRegion.cpp - Issue 18374008: Propagate writing-mode from the first region to the flow thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderRegion.cpp

Issue 18374008: Propagate writing-mode from the first region to the flow thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address minor issues raised together with the LGTM. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderRegion.cpp

diff --git a/Source/core/rendering/RenderRegion.cpp b/Source/core/rendering/RenderRegion.cpp

index 203d207afa8b76d2b40bd1781b838e356578728f..1a739f880d8e765c489a2646992c0464c2e9616e 100644

--- a/Source/core/rendering/RenderRegion.cpp

+++ b/Source/core/rendering/RenderRegion.cpp

@@ -270,6 +270,9 @@ void RenderRegion::styleDidChange(StyleDifference diff, const RenderStyle* oldSt

checkRegionStyle();

updateRegionHasAutoLogicalHeightFlag();

+ if (oldStyle && oldStyle->writingMode() != style()->writingMode())

+ m_flowThread->regionChangedWritingMode(this);

}

void RenderRegion::layoutBlock(bool relayoutChildren, LayoutUnit)

« no previous file with comments | « Source/core/rendering/RenderNamedFlowThread.cpp ('k') | no next file » | no next file with comments »