Source/core/rendering/RenderFlowThread.cpp - Issue 18374008: Propagate writing-mode from the first region to the flow thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderFlowThread.cpp

Issue 18374008: Propagate writing-mode from the first region to the flow thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address minor issues raised together with the LGTM. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderFlowThread.cpp

diff --git a/Source/core/rendering/RenderFlowThread.cpp b/Source/core/rendering/RenderFlowThread.cpp

index a6b3ae82591fbbdbd584bb334d486d8bf8507d38..f7c206156b5fb67f26edfd6b9fd89165b73af274 100644

--- a/Source/core/rendering/RenderFlowThread.cpp

+++ b/Source/core/rendering/RenderFlowThread.cpp

@@ -84,7 +84,7 @@ void RenderFlowThread::styleDidChange(StyleDifference diff, const RenderStyle* o

RenderBlock::styleDidChange(diff, oldStyle);

if (oldStyle && oldStyle->writingMode() != style()->writingMode())

- m_regionsInvalidated = true;

+ invalidateRegions();

}

void RenderFlowThread::removeFlowChildInfo(RenderObject* child)

« no previous file with comments | « Source/core/rendering/RenderFlowThread.h ('k') | Source/core/rendering/RenderNamedFlowThread.h » ('j') | no next file with comments »