Source/core/rendering/RenderFlowThread.h - Issue 18374008: Propagate writing-mode from the first region to the flow thread.

Side by Side Diff: Source/core/rendering/RenderFlowThread.h

Issue 18374008: Propagate writing-mode from the first region to the flow thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address minor issues raised together with the LGTM. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/regions/subtree-with-vert-rl-expected.html ('k') | Source/core/rendering/RenderFlowThread.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.	2 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above	8 * 1. Redistributions of source code must retain the above

9 * copyright notice, this list of conditions and the following	9 * copyright notice, this list of conditions and the following

10 * disclaimer.	10 * disclaimer.

(...skipping 69 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
80 virtual void updateLogicalWidth() OVERRIDE FINAL;	80 virtual void updateLogicalWidth() OVERRIDE FINAL;

81 virtual void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logic alTop, LogicalExtentComputedValues&) const OVERRIDE;	81 virtual void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logic alTop, LogicalExtentComputedValues&) const OVERRIDE;

82	82

83 void paintFlowThreadPortionInRegion(PaintInfo&, RenderRegion*, const LayoutR ect& flowThreadPortionRect, const LayoutRect& flowThreadPortionOverflowRect, con st LayoutPoint&) const;	83 void paintFlowThreadPortionInRegion(PaintInfo&, RenderRegion*, const LayoutR ect& flowThreadPortionRect, const LayoutRect& flowThreadPortionOverflowRect, con st LayoutPoint&) const;

84 bool hitTestFlowThreadPortionInRegion(RenderRegion*, const LayoutRect& flowT hreadPortionRect, const LayoutRect& flowThreadPortionOverflowRect, const HitTest Request&, HitTestResult&, const HitTestLocation& locationInContainer, const Layo utPoint& accumulatedOffset) const;	84 bool hitTestFlowThreadPortionInRegion(RenderRegion*, const LayoutRect& flowT hreadPortionRect, const LayoutRect& flowThreadPortionOverflowRect, const HitTest Request&, HitTestResult&, const HitTestLocation& locationInContainer, const Layo utPoint& accumulatedOffset) const;

85	85

86 bool hasRegions() const { return m_regionList.size(); }	86 bool hasRegions() const { return m_regionList.size(); }

87 // Check if the content is flown into at least a region with region styling rules.	87 // Check if the content is flown into at least a region with region styling rules.

88 bool hasRegionsWithStyling() const { return m_hasRegionsWithStyling; }	88 bool hasRegionsWithStyling() const { return m_hasRegionsWithStyling; }

89 void checkRegionsWithStyling();	89 void checkRegionsWithStyling();

	90 virtual void regionChangedWritingMode(RenderRegion*) { }

90	91

91 void validateRegions();	92 void validateRegions();

92 void invalidateRegions();	93 void invalidateRegions();

93 bool hasValidRegionInfo() const { return !m_regionsInvalidated && !m_regionL ist.isEmpty(); }	94 bool hasValidRegionInfo() const { return !m_regionsInvalidated && !m_regionL ist.isEmpty(); }

94	95

95 static PassRefPtr<RenderStyle> createFlowThreadStyle(RenderStyle* parentStyl e);	96 static PassRefPtr<RenderStyle> createFlowThreadStyle(RenderStyle* parentStyl e);

96	97

97 void styleDidChange(StyleDifference, const RenderStyle* oldStyle);	98 void styleDidChange(StyleDifference, const RenderStyle* oldStyle);

98	99

99 void repaintRectangleInRegions(const LayoutRect&) const;	100 void repaintRectangleInRegions(const LayoutRect&) const;

(...skipping 201 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
301 };	302 };

302	303

303 template <> struct ValueToString<RenderRegion*> {	304 template <> struct ValueToString<RenderRegion*> {

304 static String string(const RenderRegion* value) { return String::format("%p" , value); }	305 static String string(const RenderRegion* value) { return String::format("%p" , value); }

305 };	306 };

306 #endif	307 #endif

307	308

308 } // namespace WebCore	309 } // namespace WebCore

309	310

310 #endif // RenderFlowThread_h	311 #endif // RenderFlowThread_h

OLD	NEW