Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Issue 18374002: Compile with enable_mdns by default on Windows and Linux (Closed)

Created:
7 years, 5 months ago by Noam Samuel
Modified:
7 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Compile with enable_mdns by default on Windows and Linux This will compile MDns support by default on Windows and Linux. Note that this is separate from actually enabling MDns, which will be gated by the "--enable-device-discovery" flag. BUG=233821 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210906

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M build/common.gypi View 4 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
Noam Samuel
7 years, 5 months ago (2013-07-01 18:22:29 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm
7 years, 5 months ago (2013-07-01 18:34:53 UTC) #2
gene
lgtm
7 years, 5 months ago (2013-07-01 18:36:49 UTC) #3
szym
lgtm don't forget to set BUG=
7 years, 5 months ago (2013-07-02 17:44:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/18374002/1
7 years, 5 months ago (2013-07-02 23:04:50 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=21897
7 years, 5 months ago (2013-07-03 03:45:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/18374002/1
7 years, 5 months ago (2013-07-03 17:49:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/18374002/1
7 years, 5 months ago (2013-07-04 02:30:32 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-04 03:55:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/18374002/1
7 years, 5 months ago (2013-07-04 05:31:19 UTC) #10
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-04 06:19:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/18374002/1
7 years, 5 months ago (2013-07-04 07:10:26 UTC) #12
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-04 08:12:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/18374002/1
7 years, 5 months ago (2013-07-04 14:41:06 UTC) #14
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-04 14:54:34 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/18374002/1
7 years, 5 months ago (2013-07-04 18:16:09 UTC) #16
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-04 19:40:42 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/18374002/1
7 years, 5 months ago (2013-07-10 16:02:47 UTC) #18
Noam Samuel
On 2013/07/04 19:40:42, I haz the power (commit-bot) wrote: > Sorry for I got bad ...
7 years, 5 months ago (2013-07-10 16:02:59 UTC) #19
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 5 months ago (2013-07-10 17:34:51 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/18374002/1
7 years, 5 months ago (2013-07-10 17:36:53 UTC) #21
commit-bot: I haz the power
7 years, 5 months ago (2013-07-10 19:21:07 UTC) #22
Message was sent while issue was closed.
Change committed as 210906

Powered by Google App Engine
This is Rietveld 408576698