Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1837143002: media: Pass MediaPermission to MediaDrmBridge

Created:
4 years, 8 months ago by xhwang
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, posciak+watch_chromium.org, nasko+codewatch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Pass MediaPermission to MediaDrmBridge - Move MediaPermissionDispatcher to content/common - Create MediaPermissionDispatcher in GpuProcess. Note that MediaPermissionDispatcher can be called on any thread. - Pass MediaPermission to MojoMediaApplication. - (not finished) Pass MediaPermission to MojoMediaClient, AndroidCdmFactory and MediaDrmBridge. - (not finished) In MediaDrmBridge, check permission before generating license request. BUG=559839

Patch Set 1 #

Patch Set 2 : More plumbing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -293 lines) Patch
M content/browser/gpu/gpu_process_host.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 3 chunks +9 lines, -1 line 0 comments Download
M content/browser/media/cdm/browser_cdm_manager.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
A + content/common/media/media_permission_dispatcher.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + content/common/media/media_permission_dispatcher.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/content_common.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/gpu/gpu_child_thread.h View 1 4 chunks +15 lines, -0 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 1 3 chunks +19 lines, -1 line 0 comments Download
M content/gpu/gpu_process_control_impl.h View 1 1 chunk +8 lines, -1 line 0 comments Download
M content/gpu/gpu_process_control_impl.cc View 1 1 chunk +9 lines, -1 line 0 comments Download
D content/renderer/media/media_permission_dispatcher.h View 1 1 chunk +0 lines, -75 lines 0 comments Download
D content/renderer/media/media_permission_dispatcher.cc View 1 1 chunk +0 lines, -131 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M media/base/android/android_cdm_factory.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M media/base/android/android_cdm_factory.cc View 1 2 chunks +7 lines, -4 lines 0 comments Download
M media/base/android/media_drm_bridge.h View 1 7 chunks +18 lines, -0 lines 0 comments Download
M media/base/android/media_drm_bridge.cc View 1 14 chunks +102 lines, -69 lines 0 comments Download
M media/mojo/services/android_mojo_media_client.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M media/mojo/services/android_mojo_media_client.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M media/mojo/services/mojo_media_application_factory.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M media/mojo/services/mojo_media_application_factory.cc View 1 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 1 (1 generated)
xhwang
4 years, 8 months ago (2016-03-29 04:16:19 UTC) #1 
Description was changed from

==========
media: Pass MediaPermission to MediaDrmBridge.

BUG=559839
TEST=Permission check is executed when using MediaDrmBridge.
==========

to

==========
media: Pass MediaPermission to MediaDrmBridge

- Move MediaPermissionDispatcher to content/common
- Create MediaPermissionDispatcher in GpuProcess. Note that
MediaPermissionDispatcher can be called on any thread.
- Pass MediaPermission to MojoMediaApplication.
- (not finished) Pass MediaPermission to MojoMediaClient, AndroidCdmFactory and
MediaDrmBridge.
- (not finished) In MediaDrmBridge, check permission before generating license
request.

BUG=559839
==========

Powered by Google App Engine
This is Rietveld 408576698