Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issue 18365005: ARM Skia NEON patches - 09 - Bugfix (Closed)

Created:
7 years, 5 months ago by kevin.petit.not.used.account
Modified:
7 years, 5 months ago
Reviewers:
edisonn, djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

ARM Skia NEON patches - 09 - Bugfix Misc: fix a PDF warning/bug on ARM char is unsigned by default on ARM, so the (curNibble < 0) test is always false, probably leading to a bug. BUG= Committed: http://code.google.com/p/skia/source/detail?r=9954

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pdf/SkPDFFont.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
djsollen
lgtm, but want to loop in our PDF expert to confirm.
7 years, 5 months ago (2013-07-10 13:20:25 UTC) #1
edisonn
LGTM
7 years, 5 months ago (2013-07-10 14:08:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kevin.petit.arm@gmail.com/18365005/1
7 years, 5 months ago (2013-07-10 14:56:02 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-10 15:03:54 UTC) #4
Message was sent while issue was closed.
Change committed as 9954

Powered by Google App Engine
This is Rietveld 408576698