 Chromium Code Reviews
 Chromium Code Reviews Issue 1836073003:
  media: Use "public_configs" for "mojo_media_config"  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1836073003:
  media: Use "public_configs" for "mojo_media_config"  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: content/renderer/BUILD.gn | 
| diff --git a/content/renderer/BUILD.gn b/content/renderer/BUILD.gn | 
| index f9a554d07e7689f9cd199ed8a2dc5df0dfea6884..70afccc422dfcaeb0515a6cf15412253858cce52 100644 | 
| --- a/content/renderer/BUILD.gn | 
| +++ b/content/renderer/BUILD.gn | 
| @@ -24,9 +24,11 @@ source_set("renderer") { | 
| "//build/config/compiler:no_size_t_to_int_warning", | 
| "//content/public/common:mojo_shell_client", | 
| ] | 
| - defines = [] | 
| + defines = [] | 
| public_deps = [] | 
| + public_configs = [] | 
| + | 
| deps = [ | 
| "//base:i18n", | 
| "//cc", | 
| @@ -230,6 +232,8 @@ source_set("renderer") { | 
| deps += [ | 
| "//media/mojo/interfaces", | 
| + | 
| + # Defines in mojo_media_config are also pulled in here. | 
| "//media/mojo/services:proxy", | 
| ] | 
| } | 
| @@ -255,6 +259,12 @@ source_set("renderer") { | 
| # See comment at the top of //content/BUILD.gn for how this works. | 
| group("for_content_tests") { | 
| visibility = [ "//content/test/*" ] | 
| + | 
| + if (enable_mojo_media) { | 
| + # For the defines in mojo_media_config. | 
| + public_configs = [ "//media/mojo/services:mojo_media_config" ] | 
| 
xhwang
2016/03/28 21:34:33
Adding this to the "renderer" target doesn't work
 | 
| + } | 
| + | 
| if (!is_component_build) { | 
| public_deps = [ | 
| ":renderer", |