Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1255)

Unified Diff: Source/core/page/FrameView.cpp

Issue 18358004: Call didProgrammaticallyScroll only when ProgrammaticScrollNotifications is enabled, which is an ex… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix test. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/WebKit/chromium/tests/ProgrammaticScrollTest.cpp ('k') | Source/core/page/RuntimeEnabledFeatures.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/FrameView.cpp
diff --git a/Source/core/page/FrameView.cpp b/Source/core/page/FrameView.cpp
index fbf2d4a030b9ca7e4440721fc327f4888dae7dd6..27b2b5510430623920f241e7bc60b9f1fd64a7e9 100644
--- a/Source/core/page/FrameView.cpp
+++ b/Source/core/page/FrameView.cpp
@@ -1580,7 +1580,8 @@ void FrameView::setScrollPosition(const IntPoint& scrollPoint)
if (newScrollPosition == scrollPosition())
return;
- if (Page* page = m_frame->page())
+ Page* page = m_frame->page();
+ if (page && RuntimeEnabledFeatures::programmaticScrollNotificationsEnabled())
page->chrome().client()->didProgrammaticallyScroll(m_frame.get(), newScrollPosition);
if (requestScrollPositionUpdate(newScrollPosition))
« no previous file with comments | « Source/WebKit/chromium/tests/ProgrammaticScrollTest.cpp ('k') | Source/core/page/RuntimeEnabledFeatures.in » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698