Issue 18358004: Call didProgrammaticallyScroll only when ProgrammaticScrollNotifications is enabled, which is an ex…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18358004: Call didProgrammaticallyScroll only when ProgrammaticScrollNotifications is enabled, which is an ex… (Closed)

Created:
7 years, 5 months ago by Michael van Ouwerkerk

Modified:
7 years, 5 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, kenneth.christiansen, dglazkov+blink, eae+blinkwatch, aelias_OOO_until_Jul13, Ted C, astrange, srikanth, Miguel Garcia

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Call didProgrammaticallyScroll only when ProgrammaticScrollNotifications is enabled, which is a runtime flag. BUG=255662 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153364

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
M	Source/WebKit/chromium/tests/ProgrammaticScrollTest.cpp	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	Source/core/page/FrameView.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/page/RuntimeEnabledFeatures.in	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Michael van Ouwerkerk

Hi Adam, could you take a look at this small patch please? Thanks!

7 years, 5 months ago (2013-07-01 15:40:35 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/18358004/4001

7 years, 5 months ago (2013-07-01 17:45:19 UTC) #3

Message was sent while issue was closed.

Change committed as 153364