Issue 18355002: Move HyperlinkButtonCell to /ui/base/cocoa/controls.

Issue 18355002: Move HyperlinkButtonCell to /ui/base/cocoa/controls. (Closed)

Created:
7 years, 5 months ago by tapted

Modified:
7 years, 5 months ago

Reviewers:
Nico

CC:
chromium-reviews, extensions-reviews_chromium.org, Raman Kakilate, benquan, ahutter, chromium-apps-reviews_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, rouslan+autofillwatch_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move HyperlinkButtonCell to /ui/base/cocoa/controls. Allows Cocoa UI code outside of chrome/browser to use it. This is a precursor to http://crrev.com/18326006 BUG=138633 TEST=No functional changes. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210100

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : 3 files not actually using it #

Total comments: 2

Patch Set 4 : helpful comment #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -319 lines)			Patch
M	chrome/browser/ui/cocoa/autofill/autofill_account_chooser.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/autofill/autofill_account_chooser_unittest.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/autofill/autofill_suggestion_container.mm	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/autofill/autofill_suggestion_container_unittest.mm	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller_unittest.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/cocoa/hyperlink_button_cell.h	View		1 chunk	+0 lines, -37 lines	0 comments	Download
D	chrome/browser/ui/cocoa/hyperlink_button_cell.mm	View		1 chunk	+0 lines, -152 lines	0 comments	Download
D	chrome/browser/ui/cocoa/hyperlink_button_cell_unittest.mm	View		1 chunk	+0 lines, -111 lines	0 comments	Download
M	chrome/browser/ui/cocoa/profile_signin_confirmation_view_controller.mm	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/tab_contents/sad_tab_view.mm	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/website_settings_bubble_controller.mm	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/chrome_nibs.gyp	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
A +	ui/base/cocoa/controls/hyperlink_button_cell.h	View	1 2 3	3 chunks	+11 lines, -0 lines	0 comments	Download
A +	ui/base/cocoa/controls/hyperlink_button_cell.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	ui/base/cocoa/controls/hyperlink_button_cell_unittest.mm	View		2 chunks	+11 lines, -2 lines	0 comments	Download
M	ui/ui.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/ui_unittests.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

lgtm! https://codereview.chromium.org/18355002/diff/8001/ui/base/cocoa/controls/hyperlink_button_cell.h File ui/base/cocoa/controls/hyperlink_button_cell.h (right): https://codereview.chromium.org/18355002/diff/8001/ui/base/cocoa/controls/hyperlink_button_cell.h#newcode22 ui/base/cocoa/controls/hyperlink_button_cell.h:22: // 5. In the Size panel, set the ...

7 years, 5 months ago (2013-07-03 19:31:07 UTC) #2

tapted

https://codereview.chromium.org/18355002/diff/8001/ui/base/cocoa/controls/hyperlink_button_cell.h File ui/base/cocoa/controls/hyperlink_button_cell.h (right): https://codereview.chromium.org/18355002/diff/8001/ui/base/cocoa/controls/hyperlink_button_cell.h#newcode22 ui/base/cocoa/controls/hyperlink_button_cell.h:22: // 5. In the Size panel, set the Height ...

7 years, 5 months ago (2013-07-03 23:30:04 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/18355002/24001

7 years, 5 months ago (2013-07-03 23:32:40 UTC) #4

Message was sent while issue was closed.

Change committed as 210100

Expand Messages | Collapse Messages