Issue 18350002: Web MIDI: rename sysexEnabled to sysex

Issue 18350002: Web MIDI: rename sysexEnabled to sysex (Closed)

Created:
7 years, 5 months ago by Takashi Toyoshima

Modified:
7 years, 5 months ago

Reviewers:
Chris Rogers, abarth-chromium

CC:
blink-reviews, jamesr, dglazkov+blink, eae+blinkwatch, abarth-chromium, Chris Wilson

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Web MIDI: rename sysexEnabled to sysex To follow the latest spec, sysexEnabled option is renamed to sysex. BUG=163795 TEST=LayoutTests/webmidi/requestmidiaccess.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153368

Patch Set 1 #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -9 lines)			Patch
M	LayoutTests/webmidi/requestmidiaccess.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/webmidi/MIDIAccess.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/webmidi/MIDIAccessPromise.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/modules/webmidi/MIDIOptions.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/modules/webmidi/MIDISuccessCallback.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	public/platform/WebMIDIAccessor.h	View	1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Takashi Toyoshima

FYI: cwilso Hi Chris (Rogers), Can you take a look this change to rename sysexEnabled ...

7 years, 5 months ago (2013-07-01 11:36:45 UTC) #1

abarth-chromium

https://codereview.chromium.org/18350002/diff/1/public/platform/WebMIDIAccessor.h File public/platform/WebMIDIAccessor.h (right): https://codereview.chromium.org/18350002/diff/1/public/platform/WebMIDIAccessor.h#newcode42 public/platform/WebMIDIAccessor.h:42: // |access| is set to true if MIDIOptions.sysex is ...

7 years, 5 months ago (2013-07-01 17:40:28 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/18350002/1

7 years, 5 months ago (2013-07-01 18:40:18 UTC) #4

Message was sent while issue was closed.

Change committed as 153368

Expand Messages | Collapse Messages