Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 18345011: Move GridCoordinate and GridSpan to a separate file (Closed)

Created:
7 years, 5 months ago by Julien - ping for review
Modified:
7 years, 5 months ago
Reviewers:
eseidel
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, esprehn, ojan
Visibility:
Public.

Description

Move GridCoordinate and GridSpan to a separate file In order to implement 'grid-template', we need a way to describe a grid area's coordinates. That's what GridCoordinate is about and instead of duplicating code, splitting the classes will enable code sharing. While moving the code, added some comments about the 2 classes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153427

Patch Set 1 #

Patch Set 2 : --no-find-copies to avoid bad copy detection #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -39 lines) Patch
M Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderGrid.h View 2 chunks +2 lines, -35 lines 0 comments Download
M Source/core/rendering/RenderGrid.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
A Source/core/rendering/style/GridCoordinate.h View 1 1 chunk +79 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Julien - ping for review
Very simple refactoring for the taker!
7 years, 5 months ago (2013-07-02 00:46:02 UTC) #1
eseidel
lgtm
7 years, 5 months ago (2013-07-02 03:35:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/18345011/3001
7 years, 5 months ago (2013-07-02 03:36:04 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=14588
7 years, 5 months ago (2013-07-02 04:31:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/18345011/3001
7 years, 5 months ago (2013-07-02 14:40:15 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-02 15:16:05 UTC) #6
Message was sent while issue was closed.
Change committed as 153427

Powered by Google App Engine
This is Rietveld 408576698