LayoutTests/inspector/console/console-css-unterminated-comment.html - Issue 18345005: Reporting unterminated comments in CSS.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/inspector/console/console-css-unterminated-comment.html

Issue 18345005: Reporting unterminated comments in CSS. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../../http/tests/inspector/inspector-test.js"></script>	3 <script src="../../http/tests/inspector/inspector-test.js"></script>

4 <script src="../../http/tests/inspector/console-test.js"></script>	4 <script src="../../http/tests/inspector/console-test.js"></script>

5 <script src="resources/syntax-error.js"></script>	5

	6 <style>/*</style>
	apavlov 2013/07/01 14:46:04 We need to check other cases, like valid terminate We need to check other cases, like valid terminated comments, strings with unterminated comment inside, and a terminated comment followed by an unterminated comment. SeRya 2013/07/02 08:27:56 Done. Show quoted text On 2013/07/01 14:46:04, apavlov wrote: > We need to check other cases, like valid terminated comments, strings with > unterminated comment inside, and a terminated comment followed by an > unterminated comment. Done.
	7

6 <script>	8 <script>

	9

7 function test()	10 function test()

8 {	11 {

9 InspectorTest.dumpConsoleMessages();	12 WebInspector.console.messages.forEach(function(message)

	13 {

	14 InspectorTest.addResult(message.message);

	15 });

	16

10 InspectorTest.completeTest();	17 InspectorTest.completeTest();

11 }	18 }

	19

12 </script>	20 </script>

13 </head>	21 </head>

	22

14 <body onload="runTest()">	23 <body onload="runTest()">

15 <p>	24 <p id="p">Tests that unterminated comment in CSS generates a warning.</p>

16 Tests that syntax errors are logged into console and doesn't cause browser crash .

17 </p>

18 </body>	25 </body>

19 </html>	26 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/inspector/console/console-css-unterminated-comment-expected.txt » ('j') | no next file with comments »